Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] [8.8] [Search Application] Fix indices action url #157861

Merged
merged 3 commits into from
May 16, 2023

Conversation

joemcelroy
Copy link
Member

@joemcelroy joemcelroy commented May 16, 2023

Untitled.mov

Expected: clicking on the eye icon, the user should be taken to the index view page
actual: 404 page

@joemcelroy joemcelroy requested a review from a team May 16, 2023 11:23
@joemcelroy joemcelroy changed the title [Enterprise Search] [Search Application] Fix indices action url [Enterprise Search] [8.8] [Search Application] Fix indices action url May 16, 2023
Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joemcelroy joemcelroy enabled auto-merge (squash) May 16, 2023 12:13
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.4MB 2.4MB +41.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 16, 2023
…elastic#157861)

https://github.com/elastic/kibana/assets/49480/65c2e8fe-b4b6-4ac2-86d5-85fdc88ede15

Expected: clicking on the eye icon, the user should be taken to the
index view page
actual: 404 page

(cherry picked from commit 8bdc9fa)
kibanamachine added a commit that referenced this pull request May 16, 2023
…on url (#157861) (#157873)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] [8.8] [Search Application] Fix indices action url
(#157861)](#157861)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Joseph
McElroy","email":"joseph.mcelroy@elastic.co"},"sourceCommit":{"committedDate":"2023-05-16T12:24:34Z","message":"[Enterprise
Search] [8.8] [Search Application] Fix indices action url
(#157861)\n\nhttps://github.com/elastic/kibana/assets/49480/65c2e8fe-b4b6-4ac2-86d5-85fdc88ede15\r\n\r\n\r\nExpected:
clicking on the eye icon, the user should be taken to the\r\nindex view
page\r\nactual: 404
page","sha":"8bdc9fa02d2e6da735b8dbc2cb3afb0f7a9b15ce","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":157861,"url":"https://github.com/elastic/kibana/pull/157861","mergeCommit":{"message":"[Enterprise
Search] [8.8] [Search Application] Fix indices action url
(#157861)\n\nhttps://github.com/elastic/kibana/assets/49480/65c2e8fe-b4b6-4ac2-86d5-85fdc88ede15\r\n\r\n\r\nExpected:
clicking on the eye icon, the user should be taken to the\r\nindex view
page\r\nactual: 404
page","sha":"8bdc9fa02d2e6da735b8dbc2cb3afb0f7a9b15ce"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157861","number":157861,"mergeCommit":{"message":"[Enterprise
Search] [8.8] [Search Application] Fix indices action url
(#157861)\n\nhttps://github.com/elastic/kibana/assets/49480/65c2e8fe-b4b6-4ac2-86d5-85fdc88ede15\r\n\r\n\r\nExpected:
clicking on the eye icon, the user should be taken to the\r\nindex view
page\r\nactual: 404
page","sha":"8bdc9fa02d2e6da735b8dbc2cb3afb0f7a9b15ce"}}]}] BACKPORT-->

Co-authored-by: Joseph McElroy <joseph.mcelroy@elastic.co>
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants