[Security Solution] Fix grouping rows per page bug #157807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
stephmilovic
commented
May 16, 2023
| @@ -149,6 +149,12 @@ const GroupedAlertsTableComponent: React.FC<AlertsTableComponentProps> = (props) | |||
| setStoragePageSize(newArr); | |||
| return newArr; | |||
| }); | |||
| // set page index to 0 when page size is changed | |||
| setPageIndex((currentIndex) => { | |||
There was a problem hiding this comment.
this is the bug fix
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 16, 2023
(cherry picked from commit 8181597)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 16, 2023
…157884) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Fix grouping rows per page bug (#157807)](#157807) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2023-05-16T14:15:23Z","message":"[Security Solution] Fix grouping rows per page bug (#157807)","sha":"8181597cc9f422b38341761b308db6b3176614bf","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","v8.8.0","v8.9.0"],"number":157807,"url":"https://github.com/elastic/kibana/pull/157807","mergeCommit":{"message":"[Security Solution] Fix grouping rows per page bug (#157807)","sha":"8181597cc9f422b38341761b308db6b3176614bf"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157807","number":157807,"mergeCommit":{"message":"[Security Solution] Fix grouping rows per page bug (#157807)","sha":"8181597cc9f422b38341761b308db6b3176614bf"}}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #156515
We were not reseting the active page to 0 when rows per page changed. If we had 100 groups with rows per page set to 10, and navigate to page 10. Then set rows per page to 100. Because we are still on page 10, it is querying for results 900-1000 which do not exist. It shows an empty page. We need to reset to page 1 to make sure data still exists for the page we are loading.