Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Added component for rendering dashboard-based service runtime metrics #157724

Merged
merged 5 commits into from
May 23, 2023
Merged

[APM] Added component for rendering dashboard-based service runtime metrics #157724

merged 5 commits into from
May 23, 2023

Conversation

AlexanderWert
Copy link
Member

@AlexanderWert AlexanderWert commented May 15, 2023 •
edited by sorenlouv
Loading

Pitch: https://github.com/elastic/apm-dev/issues/1001 (internal)

Summary

Use portable dashboards for runtime metrics as a fallback.

Example dashboard:
image

@AlexanderWert AlexanderWert added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label May 15, 2023
@AlexanderWert AlexanderWert requested a review from a team as a code owner May 15, 2023 13:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@AlexanderWert AlexanderWert changed the title Added component for rendering dashboard-based service runtime metrics [APM] Added component for rendering dashboard-based service runtime metrics May 15, 2023
@sorenlouv
Copy link
Member

/oblt-deploy

@AlexanderWert AlexanderWert added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels May 17, 2023
@AlexanderWert
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@AlexanderWert AlexanderWert force-pushed the portable-runtime-metric branch from 0f2c7fd to 6d6f2fc Compare May 17, 2023 07:51
@AlexanderWert
Copy link
Member Author

AlexanderWert commented May 17, 2023 •
edited
Loading

@sqren I don't get what the failed check is about exactly. I don't see any name attribute in the one place where I used i18n in this PR.

Do you have an idea?

Thanks

@sorenlouv
Copy link
Member

@AlexanderWert That is indeed weird. Try running the check locally to see if you get the same error node scripts/i18n_check.js --fix.

This might be a bug upstream. Try rebasing with main.

AlexanderWert and others added 4 commits May 22, 2023 07:48
@AlexanderWert
Added component for rendering dashboard-based service runtime metrics
c951310 
Signed-off-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
@kibanamachine @AlexanderWert
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
2f072c0 
…fix'
@AlexanderWert
Fixed Node.js dashboard file
d980630 
Signed-off-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
@AlexanderWert
Fixed i18n check
f725ee9 
Signed-off-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
@AlexanderWert AlexanderWert force-pushed the portable-runtime-metric branch from 6d6f2fc to f725ee9 Compare May 22, 2023 07:57
sorenlouv
sorenlouv reviewed May 22, 2023
View reviewed changes
x-pack/plugins/apm/public/components/app/metrics/static_dashboard/helper.ts Outdated
import type { DashboardPanelMap } from '@kbn/dashboard-plugin/common';
import { APM_STATIC_DATA_VIEW_ID } from '../../../../../common/data_view_constants';

import nodejs from './dashboards/nodejs.json';
Copy link
Member

@sorenlouv sorenlouv May 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We might want to import these dynamically to avoid increasing the bundle size. Right now the APM app increases with 27kb which is not terrible but if 20 dashboards are loaded up front it might be noticeable.

The syntax is something like this:

await import(path)

And you'd have to defer loading it, until you actually need it (in getDashboardFile I assume)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sqren Pushed a commit with dynamic importing of the dashboard files.

@AlexanderWert
Made the dashboards import dynamic.
ca16a36 
Signed-off-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1351 1355 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +28.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 33.0KB 33.4KB +416.0B
Unknown metric groups

async chunk count

id before after diff
apm 26 27 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv
sorenlouv approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @AlexanderWert

@AlexanderWert AlexanderWert merged commit f1ea233 into elastic:main May 23, 2023
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
@AlexanderWert @kibanamachine @delanni
[APM] Added component for rendering dashboard-based service runtime m…
4118a73 
…etrics (elastic#157724)

Pitch: elastic/apm-dev#1001 (_internal_)

## Summary

Use portable dashboards for runtime metrics as a fallback.

Example dashboard:
<img width="1588" alt="image"
src="https://github.com/elastic/kibana/assets/866830/ee46582d-60db-4538-925f-e9729e77e70b">

---------

Signed-off-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@AlexanderWert AlexanderWert mentioned this pull request Jun 22, 2023
Open
5 tasks
@gbamparop
Copy link
Contributor

Tested on edge-oblt:

Screen.Recording.2023-06-23.at.15.34.14.mov

@gbamparop gbamparop added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AlexanderWert @elasticmachine @apmmachine @sorenlouv @kibanamachine @kibana-ci @gbamparop