-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] adjust esquery refreshes settings #157323
Conversation
9e88585
to
4559065
Compare
|
||
// Since the contents of the table have changed, we must reset the pagination | ||
// and re-fetch. Otherwise, the Nth page we are on could be empty of jobs. | ||
this.setState(() => ({ page: 0 }), this.fetchJobs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without refresh after delete, this fetchJobs
tends to predicable stale report artifacts for recently deleted reoprts in the list.
4559065
to
cb41969
Compare
Pinging @elastic/appex-sharedux (Team:SharedUX) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @tsullivan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally with sample data - reporting LGTM!
wait_for
Summary
https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-refresh.html
The goal is to use a
refresh
value of"wait_for"
orfalse
for Reporting's Index, Update, Delete, and Bulk operations, to limit negative impacts to search and indexing performance.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: