[Fleet] Do not show error state on input if there are no errors #157160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @hop-dev |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 9, 2023
…tic#157160) ## Summary Fixes this bug, where there was previously an error with this input but it has been solved, we still have it in the error state: <img width="1030" alt="Screenshot 2023-05-09 at 12 26 04" src="https://github.com/elastic/kibana/assets/3315046/4381523a-d839-4425-af5f-0f56e6aa9199"> Note there is no error message, where a correct error input looks like this: <img width="379" alt="Screenshot 2023-05-09 at 12 27 44" src="https://github.com/elastic/kibana/assets/3315046/4b7a498a-ac9a-46d8-94e1-525f4b090cfd"> The error is simply that `[]` is truthy so was showing as having errors (cherry picked from commit 5ceeaa0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 9, 2023
…#157160) (#157172) # Backport This will backport the following commits from `main` to `8.8`: - [[Fleet] Do not show error state on input if there are no errors (#157160)](#157160) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"mark.hopkin@elastic.co"},"sourceCommit":{"committedDate":"2023-05-09T14:15:27Z","message":"[Fleet] Do not show error state on input if there are no errors (#157160)\n\n## Summary\r\nFixes this bug, where there was previously an error with this input but\r\nit has been solved, we still have it in the error state:\r\n<img width=\"1030\" alt=\"Screenshot 2023-05-09 at 12 26 04\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/4381523a-d839-4425-af5f-0f56e6aa9199\">\r\n\r\nNote there is no error message, where a correct error input looks like\r\nthis:\r\n<img width=\"379\" alt=\"Screenshot 2023-05-09 at 12 27 44\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/4b7a498a-ac9a-46d8-94e1-525f4b090cfd\">\r\n\r\nThe error is simply that `[]` is truthy so was showing as having errors","sha":"5ceeaa0333025f6ff6e28208a367e05622b40dc6","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v8.8.0","v8.9.0"],"number":157160,"url":"https://github.com/elastic/kibana/pull/157160","mergeCommit":{"message":"[Fleet] Do not show error state on input if there are no errors (#157160)\n\n## Summary\r\nFixes this bug, where there was previously an error with this input but\r\nit has been solved, we still have it in the error state:\r\n<img width=\"1030\" alt=\"Screenshot 2023-05-09 at 12 26 04\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/4381523a-d839-4425-af5f-0f56e6aa9199\">\r\n\r\nNote there is no error message, where a correct error input looks like\r\nthis:\r\n<img width=\"379\" alt=\"Screenshot 2023-05-09 at 12 27 44\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/4b7a498a-ac9a-46d8-94e1-525f4b090cfd\">\r\n\r\nThe error is simply that `[]` is truthy so was showing as having errors","sha":"5ceeaa0333025f6ff6e28208a367e05622b40dc6"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157160","number":157160,"mergeCommit":{"message":"[Fleet] Do not show error state on input if there are no errors (#157160)\n\n## Summary\r\nFixes this bug, where there was previously an error with this input but\r\nit has been solved, we still have it in the error state:\r\n<img width=\"1030\" alt=\"Screenshot 2023-05-09 at 12 26 04\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/4381523a-d839-4425-af5f-0f56e6aa9199\">\r\n\r\nNote there is no error message, where a correct error input looks like\r\nthis:\r\n<img width=\"379\" alt=\"Screenshot 2023-05-09 at 12 27 44\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/4b7a498a-ac9a-46d8-94e1-525f4b090cfd\">\r\n\r\nThe error is simply that `[]` is truthy so was showing as having errors","sha":"5ceeaa0333025f6ff6e28208a367e05622b40dc6"}}]}] BACKPORT--> Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes this bug, where there was previously an error with a policy input but it has been corrected by the user, we still show it in the error state without an error message:
Note there is no error message, where a correct error input looks like this:
The error is simply that
[]is truthy so was showing as having errors