fix(slo): enforce write capabilities on welcome and form pages #157153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @kdelemme |
benakansara
reviewed
May 9, 2023
There was a problem hiding this comment.
@kdelemme When accessing http://localhost:5601/app/observability/slos with "None" SLO privileges, the screen is flickering. Did you intend to fix that too in this PR?
|
@benakansara Not this one in this PR. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 9, 2023
…ic#157153) (cherry picked from commit 0743600)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 9, 2023
…157153) (#157183) # Backport This will backport the following commits from `main` to `8.8`: - [fix(slo): enforce write capabilities on welcome and form pages (#157153)](#157153) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2023-05-09T14:17:42Z","message":"fix(slo): enforce write capabilities on welcome and form pages (#157153)","sha":"07436005b8ca1d54cece0d25000839f49304d62b","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: Actionable Observability","backport:prev-minor","v8.9.0"],"number":157153,"url":"https://github.com/elastic/kibana/pull/157153","mergeCommit":{"message":"fix(slo): enforce write capabilities on welcome and form pages (#157153)","sha":"07436005b8ca1d54cece0d25000839f49304d62b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157153","number":157153,"mergeCommit":{"message":"fix(slo): enforce write capabilities on welcome and form pages (#157153)","sha":"07436005b8ca1d54cece0d25000839f49304d62b"}}]}] BACKPORT--> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #157150
Summary
This PR fixes the welcome and form pages when a user has not the write capabilities: