Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Synthetics] quote monitor name to prevent invalid yaml" #157143

Merged
merged 1 commit into from
May 9, 2023
Merged

Revert "[Synthetics] quote monitor name to prevent invalid yaml" #157143

merged 1 commit into from
May 9, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented May 9, 2023 •
edited by kibanamachine
Loading

Reverts #156210

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #4 / saved objects spaces only enabled _resolve within the space_2 space "before all" hook for "should return 200 success [resolvetype/exact-match]"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB -60.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 403 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 483 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 marked this pull request as ready for review May 9, 2023 11:03
@shahzad31 shahzad31 requested a review from a team as a code owner May 9, 2023 11:03
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.8.0 v8.9.0 labels May 9, 2023
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 merged commit 6220fae into main May 9, 2023
@shahzad31 shahzad31 deleted the revert-156210-fix/synthetics-quote-monitor-name branch May 9, 2023 11:15
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.8 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

node scripts/backport --pr 157143

Questions ?

Please refer to the Backport tool documentation

@dominiqueclarke dominiqueclarke mentioned this pull request May 9, 2023
Merged
@dominiqueclarke
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dominiqueclarke pushed a commit to dominiqueclarke/kibana that referenced this pull request May 9, 2023
@shahzad31
Revert "[Synthetics] quote monitor name to prevent invalid yaml" (ela…
c174ff4 
…stic#157143)

(cherry picked from commit 6220fae)
dominiqueclarke added a commit that referenced this pull request May 9, 2023
@dominiqueclarke @shahzad31
[8.8] Revert "[Synthetics] quote monitor name to prevent invalid yaml" (
d10ba61 
#157143) (#157199)

# Backport

This will backport the following commits from `main` to `8.8`:
- [Revert "[Synthetics] quote monitor name to prevent invalid yaml"
(#157143)](#157143)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-05-09T11:15:46Z","message":"Revert
\"[Synthetics] quote monitor name to prevent invalid yaml\"
(#157143)","sha":"6220fae002425f4e955537c312d0e4e3c9d2bc2d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.8.0","v8.9.0"],"number":157143,"url":"https://github.com/elastic/kibana/pull/157143","mergeCommit":{"message":"Revert
\"[Synthetics] quote monitor name to prevent invalid yaml\"
(#157143)","sha":"6220fae002425f4e955537c312d0e4e3c9d2bc2d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157143","number":157143,"mergeCommit":{"message":"Revert
\"[Synthetics] quote monitor name to prevent invalid yaml\"
(#157143)","sha":"6220fae002425f4e955537c312d0e4e3c9d2bc2d"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shahzad31 @apmmachine @kibana-ci @elasticmachine @kibanamachine @dominiqueclarke @awahab07