[Synthetics] adjust view errors detail link for project and ui monitors #157063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/uptime (Team:uptime) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
@elasticmachine merge upstream |
shahzad31
approved these changes
May 8, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 8, 2023
…rs (elastic#157063) ## Summary Adjusts the View Error Details link on the Monitor Details page to use the correct config id. Previously, the url was using the monitor query id, which is different than the config id for project monitors. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 32d3ac2)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 8, 2023
…rs (elastic#157063) ## Summary Adjusts the View Error Details link on the Monitor Details page to use the correct config id. Previously, the url was using the monitor query id, which is different than the config id for project monitors. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 32d3ac2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 8, 2023
…monitors (#157063) (#157089) # Backport This will backport the following commits from `main` to `8.7`: - [[Synthetics] adjust view errors detail link for project and ui monitors (#157063)](#157063) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T21:21:35Z","message":"[Synthetics] adjust view errors detail link for project and ui monitors (#157063)\n\n## Summary\r\n\r\nAdjusts the View Error Details link on the Monitor Details page to use\r\nthe correct config id.\r\n\r\nPreviously, the url was using the monitor query id, which is different\r\nthan the config id for project monitors.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"32d3ac27f5ba8fa94e121972ccaf7ae0b27d95a8","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.8.0","v8.7.2","v8.9.0"],"number":157063,"url":"https://github.com/elastic/kibana/pull/157063","mergeCommit":{"message":"[Synthetics] adjust view errors detail link for project and ui monitors (#157063)\n\n## Summary\r\n\r\nAdjusts the View Error Details link on the Monitor Details page to use\r\nthe correct config id.\r\n\r\nPreviously, the url was using the monitor query id, which is different\r\nthan the config id for project monitors.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"32d3ac27f5ba8fa94e121972ccaf7ae0b27d95a8"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157063","number":157063,"mergeCommit":{"message":"[Synthetics] adjust view errors detail link for project and ui monitors (#157063)\n\n## Summary\r\n\r\nAdjusts the View Error Details link on the Monitor Details page to use\r\nthe correct config id.\r\n\r\nPreviously, the url was using the monitor query id, which is different\r\nthan the config id for project monitors.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"32d3ac27f5ba8fa94e121972ccaf7ae0b27d95a8"}}]}] BACKPORT--> Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
May 9, 2023
…monitors (#157063) (#157090) # Backport This will backport the following commits from `main` to `8.8`: - [[Synthetics] adjust view errors detail link for project and ui monitors (#157063)](#157063) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T21:21:35Z","message":"[Synthetics] adjust view errors detail link for project and ui monitors (#157063)\n\n## Summary\r\n\r\nAdjusts the View Error Details link on the Monitor Details page to use\r\nthe correct config id.\r\n\r\nPreviously, the url was using the monitor query id, which is different\r\nthan the config id for project monitors.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"32d3ac27f5ba8fa94e121972ccaf7ae0b27d95a8","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.8.0","v8.7.2","v8.9.0"],"number":157063,"url":"https://github.com/elastic/kibana/pull/157063","mergeCommit":{"message":"[Synthetics] adjust view errors detail link for project and ui monitors (#157063)\n\n## Summary\r\n\r\nAdjusts the View Error Details link on the Monitor Details page to use\r\nthe correct config id.\r\n\r\nPreviously, the url was using the monitor query id, which is different\r\nthan the config id for project monitors.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"32d3ac27f5ba8fa94e121972ccaf7ae0b27d95a8"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157063","number":157063,"mergeCommit":{"message":"[Synthetics] adjust view errors detail link for project and ui monitors (#157063)\n\n## Summary\r\n\r\nAdjusts the View Error Details link on the Monitor Details page to use\r\nthe correct config id.\r\n\r\nPreviously, the url was using the monitor query id, which is different\r\nthan the config id for project monitors.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"32d3ac27f5ba8fa94e121972ccaf7ae0b27d95a8"}}]}] BACKPORT--> Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjusts the View Error Details link on the Monitor Details page to use the correct config id.
Previously, the url was using the monitor query id, which is different than the config id for project monitors.