Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Add link and add validations #157028

Merged
merged 3 commits into from
May 9, 2023
Merged

[RAM] Add link and add validations #157028

merged 3 commits into from
May 9, 2023

Conversation

guskovaue
Copy link
Contributor

@guskovaue guskovaue commented May 8, 2023 •
edited by kibanamachine
Loading

In this PR:

  1. I add a link to Slack Web API docs in UI
  2. Add some limitations to parameters schema for Slack Web API connector.

@guskovaue guskovaue added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels May 8, 2023
@guskovaue guskovaue self-assigned this May 8, 2023
@guskovaue guskovaue marked this pull request as ready for review May 8, 2023 17:07
@guskovaue guskovaue requested review from a team as code owners May 8, 2023 17:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@guskovaue guskovaue added the release_note:skip Skip the PR/issue when compiling release notes label May 8, 2023
lcawl
lcawl approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc link changes LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 157.6KB 157.7KB +78.0B
stackConnectors 423.4KB 423.7KB +319.0B
total +397.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 363.6KB 363.7KB +78.0B
stackConnectors 29.9KB 29.9KB +24.0B
total +102.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 403 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 483 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @guskovaue

@guskovaue guskovaue merged commit 12162a0 into elastic:main May 9, 2023
@kibanamachine kibanamachine mentioned this pull request May 9, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 9, 2023
@guskovaue
[RAM] Add link and add validations (elastic#157028)
b4cae69 
In this PR:
1. I add a link to Slack Web API docs in UI
2. Add some limitations to parameters schema for Slack Web API
connector.

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
(cherry picked from commit 12162a0)
kibanamachine added a commit that referenced this pull request May 9, 2023
@kibanamachine @guskovaue
[8.8] [RAM] Add link and add validations (#157028) (#157134)
1401b1a 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[RAM] Add link and add validations
(#157028)](#157028)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Julia","email":"iuliia.guskova@elastic.co"},"sourceCommit":{"committedDate":"2023-05-09T07:07:36Z","message":"[RAM]
Add link and add validations (#157028)\n\nIn this PR:\r\n1. I add a link
to Slack Web API docs in UI\r\n2. Add some limitations to parameters
schema for Slack Web
API\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Lisa Cawley
<lcawley@elastic.co>","sha":"12162a0b3f85f5594e8f54ca9c14d014e926720d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport:prev-minor","v8.9.0"],"number":157028,"url":"https://github.com/elastic/kibana/pull/157028","mergeCommit":{"message":"[RAM]
Add link and add validations (#157028)\n\nIn this PR:\r\n1. I add a link
to Slack Web API docs in UI\r\n2. Add some limitations to parameters
schema for Slack Web
API\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Lisa Cawley
<lcawley@elastic.co>","sha":"12162a0b3f85f5594e8f54ca9c14d014e926720d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157028","number":157028,"mergeCommit":{"message":"[RAM]
Add link and add validations (#157028)\n\nIn this PR:\r\n1. I add a link
to Slack Web API docs in UI\r\n2. Add some limitations to parameters
schema for Slack Web
API\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Lisa Cawley
<lcawley@elastic.co>","sha":"12162a0b3f85f5594e8f54ca9c14d014e926720d"}}]}]
BACKPORT-->

Co-authored-by: Julia <iuliia.guskova@elastic.co>
pmuellr
pmuellr reviewed May 9, 2023
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr left review comments

@lcawl lcawl lcawl approved these changes

Assignees

@guskovaue guskovaue

Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 v8.9.0
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guskovaue @elasticmachine @kibana-ci @kibanamachine @pmuellr @lcawl