Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SloDetails Locator #156995

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

CoenWarmer
Copy link
Contributor

Resolves #155873

πŸ“ Summary

This PR adds an SLO Details Locator and exposes it to other Kibana apps via the Observability plugin definition.

βœ… Checklist

  • A Locator for SLO Details should be created
  • The locator should be exposed via the Observability Plugin Setup function

@CoenWarmer CoenWarmer requested a review from a team as a code owner May 8, 2023 13:31
@apmmachine
Copy link
Contributor

πŸ€– GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels May 8, 2023
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing

Co-authored-by: Kevin Delemme <kdelemme@gmail.com>
@CoenWarmer CoenWarmer enabled auto-merge (squash) May 8, 2023 14:00
@CoenWarmer CoenWarmer requested a review from kdelemme May 8, 2023 14:22
@kibana-ci
Copy link
Collaborator

πŸ’› Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 408 409 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 552 553 +1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observability 25 27 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 56.3KB 56.8KB +417.0B
Unknown metric groups

API count

id before after diff
observability 558 559 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
observability 34 35 +1
securitySolution 398 401 +3
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
observability 38 39 +1
securitySolution 478 481 +3
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 1506cb2 into elastic:main May 8, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] Create locator for SLOs via Observability plugin
5 participants