Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to make Cases FTR tests less fragile #156972

Merged
merged 1 commit into from
May 8, 2023
Merged

Attempt to make Cases FTR tests less fragile #156972

merged 1 commit into from
May 8, 2023

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented May 8, 2023 •
edited by kibanamachine
Loading

Resolves #156895
Resolves #156587
Resolves #156312

Summary

This is an attempt to make the Cases FTR tests less fragile.

@CoenWarmer CoenWarmer requested a review from a team as a code owner May 8, 2023 11:35
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.8.0 labels May 8, 2023
@CoenWarmer CoenWarmer enabled auto-merge (squash) May 8, 2023 11:40
kdelemme
kdelemme approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try :)
I wonder how much we need this FTR tests though... They kind of test the presence of buttons here and there. Unit test would be as good.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 6ad8c42 into elastic:main May 8, 2023
@CoenWarmer
Copy link
Contributor Author

CoenWarmer commented May 8, 2023 •
edited
Loading

Let's try :) I wonder how much we need this FTR tests though... They kind of test the presence of buttons here and there. Unit test would be as good.

Agreed! They're quite expensive and can be quite flaky.

@kibanamachine kibanamachine mentioned this pull request May 8, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2023
@CoenWarmer
Attempt to make Cases FTR tests less fragile (elastic#156972)
7cf30fe 
(cherry picked from commit 6ad8c42)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 8, 2023
@kibanamachine @CoenWarmer
[8.8] Attempt to make Cases FTR tests less fragile (#156972) (#156983)
5b0052e 
# Backport

This will backport the following commits from `main` to `8.8`:
- [Attempt to make Cases FTR tests less fragile
(#156972)](#156972)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Coen
Warmer","email":"coen.warmer@gmail.com"},"sourceCommit":{"committedDate":"2023-05-08T12:28:00Z","message":"Attempt
to make Cases FTR tests less fragile
(#156972)","sha":"6ad8c42d58a30e8188776bf56479124e7941f569","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.8.0","v8.9.0"],"number":156972,"url":"https://github.com/elastic/kibana/pull/156972","mergeCommit":{"message":"Attempt
to make Cases FTR tests less fragile
(#156972)","sha":"6ad8c42d58a30e8188776bf56479124e7941f569"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156972","number":156972,"mergeCommit":{"message":"Attempt
to make Cases FTR tests less fragile
(#156972)","sha":"6ad8c42d58a30e8188776bf56479124e7941f569"}}]}]
BACKPORT-->

Co-authored-by: Coen Warmer <coen.warmer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack Observability UI Functional Tests.x-pack/test/observability_functional/apps/observability/pages/alerts/add_to_case·ts - ObservabilityApp Observability alerts / Add to case > When user has read permissions for cases "before all" hook for "does not render case options in the overflow menu" Failing test: Chrome X-Pack Observability UI Functional Tests.x-pack/test/observability_functional/apps/observability/pages/alerts/add_to_case·ts - ObservabilityApp Observability alerts / Add to case > When user has all privileges for cases "before all" hook for "renders case options in the overflow menu" Failing test: Chrome X-Pack Observability UI Functional Tests.x-pack/test/observability_functional/apps/observability/pages/alerts/add_to_case·ts - ObservabilityApp Observability alerts / Add to case > When user has all privileges for cases opens a modal when Add to existing case is clicked
5 participants
@CoenWarmer @apmmachine @kibana-ci @kibanamachine @kdelemme