Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build a connector document link #156967

Merged
merged 1 commit into from
May 8, 2023

Conversation

efegurkan
Copy link
Member

@efegurkan efegurkan commented May 8, 2023

Summary

Fixes the docLink for "build-connector". This was going to a 404 due to a small typo.

@efegurkan efegurkan added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0 labels May 8, 2023
@efegurkan efegurkan requested a review from a team as a code owner May 8, 2023 09:08
@efegurkan efegurkan enabled auto-merge (squash) May 8, 2023 09:08
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 157.5KB 157.5KB -21.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 363.5KB 363.5KB -21.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doclink LGTM

@efegurkan efegurkan merged commit 9b356f9 into elastic:main May 8, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2023
## Summary

Fixes the docLink for "build-connector". This was going to a 404 due to
a small typo.

(cherry picked from commit 9b356f9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 8, 2023
# Backport

This will backport the following commits from `main` to `8.8`:
- [Fix build a connector document link
(#156967)](#156967)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Efe Gürkan
YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T14:15:15Z","message":"Fix
build a connector document link (#156967)\n\n## Summary\r\n\r\nFixes the
docLink for \"build-connector\". This was going to a 404 due to\r\na
small
typo.","sha":"9b356f994be58de43f101bde0f051d783c34f449","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156967,"url":"https://github.com/elastic/kibana/pull/156967","mergeCommit":{"message":"Fix
build a connector document link (#156967)\n\n## Summary\r\n\r\nFixes the
docLink for \"build-connector\". This was going to a 404 due to\r\na
small
typo.","sha":"9b356f994be58de43f101bde0f051d783c34f449"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156967","number":156967,"mergeCommit":{"message":"Fix
build a connector document link (#156967)\n\n## Summary\r\n\r\nFixes the
docLink for \"build-connector\". This was going to a 404 due to\r\na
small typo.","sha":"9b356f994be58de43f101bde0f051d783c34f449"}}]}]
BACKPORT-->

Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co>
@efegurkan efegurkan deleted the fix-build-connector-doc-link branch October 26, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants