Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide preview charts in APM rules #156966

Merged
merged 4 commits into from
May 8, 2023
Merged

Hide preview charts in APM rules #156966

merged 4 commits into from
May 8, 2023

Conversation

benakansara
Copy link
Contributor

@benakansara benakansara commented May 8, 2023 •
edited by kibanamachine
Loading

Hides preview charts in the following APM rules until #156625 (WIP) gets merged.

  • APM Latency threshold
  • APM Failed transaction rate
  • APM Error count threshold

@benakansara benakansara added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 v8.9.0 labels May 8, 2023
@benakansara benakansara self-assigned this May 8, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@benakansara benakansara marked this pull request as ready for review May 8, 2023 09:08
@benakansara benakansara requested a review from a team as a code owner May 8, 2023 09:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label May 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@benakansara
Copy link
Contributor Author

@kpatticha @sqren
I have started working on fixing the preview charts (#156625). I fixed the charts for Latency threshold and Failed transaction rate rules. But I think we won't be left with enough time to test everything thoroughly for 8.8. So I am hiding the charts for now as we discussed earlier, and I will continue with this PR for 8.9.

@benakansara benakansara requested a review from a team May 8, 2023 09:15
@benakansara benakansara enabled auto-merge (squash) May 8, 2023 09:15
@benakansara benakansara disabled auto-merge May 8, 2023 10:00
sorenlouv
sorenlouv approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

sorenlouv

This comment was marked as duplicate.

Sign in to view

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB -481.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @benakansara

@benakansara benakansara merged commit d10c48b into elastic:main May 8, 2023
@kibanamachine kibanamachine mentioned this pull request May 8, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2023
@benakansara
Hide preview charts in APM rules (elastic#156966)
31c19fc 
Hides preview charts in the following APM rules until
elastic#156625 (WIP) gets merged.

- APM Latency threshold
- APM Failed transaction rate
- APM Error count threshold

(cherry picked from commit d10c48b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 8, 2023
@kibanamachine @benakansara
[8.8] Hide preview charts in APM rules (#156966) (#156971)
1f6d2bf 
# Backport

This will backport the following commits from `main` to `8.8`:
- [Hide preview charts in APM rules
(#156966)](#156966)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-08T11:12:08Z","message":"Hide
preview charts in APM rules (#156966)\n\nHides preview charts in the
following APM rules
until\r\nhttps://github.com//pull/156625 (WIP) gets
merged.\r\n\r\n- APM Latency threshold\r\n- APM Failed transaction
rate\r\n- APM Error count
threshold","sha":"d10c48b983404025c6b0009c899ccc59c655bc6d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","Team:
Actionable
Observability","v8.8.0","v8.9.0"],"number":156966,"url":"https://github.com/elastic/kibana/pull/156966","mergeCommit":{"message":"Hide
preview charts in APM rules (#156966)\n\nHides preview charts in the
following APM rules
until\r\nhttps://github.com//pull/156625 (WIP) gets
merged.\r\n\r\n- APM Latency threshold\r\n- APM Failed transaction
rate\r\n- APM Error count
threshold","sha":"d10c48b983404025c6b0009c899ccc59c655bc6d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156966","number":156966,"mergeCommit":{"message":"Hide
preview charts in APM rules (#156966)\n\nHides preview charts in the
following APM rules
until\r\nhttps://github.com//pull/156625 (WIP) gets
merged.\r\n\r\n- APM Latency threshold\r\n- APM Failed transaction
rate\r\n- APM Error count
threshold","sha":"d10c48b983404025c6b0009c899ccc59c655bc6d"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
@kpatticha
Copy link
Contributor

@kpatticha @sqren I have started working on fixing the preview charts (#156625). I fixed the charts for Latency threshold and Failed transaction rate rules. But I think we won't be left with enough time to test everything thoroughly for 8.8. So I am hiding the charts for now as we discussed earlier, and I will continue with this PR for 8.9.

Thanks @benakansara

@benakansara benakansara deleted the bugfix/hide-preview-chart-in-apm-rules branch October 23, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@yngrdyn yngrdyn yngrdyn approved these changes

@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes

Assignees

@benakansara benakansara

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@benakansara @apmmachine @elasticmachine @kibana-ci @kibanamachine @kpatticha @sorenlouv @yngrdyn @maryam-saeidi