-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Enterprise Search guide links #156965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 8, 2023
## Summary Fixes Enterprise Search guided onboarding links which broke due to UI changes recently. https://user-images.githubusercontent.com/1410658/236779703-010884f0-7708-43e0-8f77-e3e0be456452.mov (cherry picked from commit e36327c)
kibanamachine
added a commit
that referenced
this pull request
May 8, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [Fix Enterprise Search guide links (#156965)](#156965) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Efe Gürkan YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T09:51:57Z","message":"Fix Enterprise Search guide links (#156965)\n\n## Summary\r\n\r\nFixes Enterprise Search guided onboarding links which broke due to UI\r\nchanges recently.\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1410658/236779703-010884f0-7708-43e0-8f77-e3e0be456452.mov","sha":"e36327c243680ad5695a86fbb038062e1bf34816","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156965,"url":"https://github.com/elastic/kibana/pull/156965","mergeCommit":{"message":"Fix Enterprise Search guide links (#156965)\n\n## Summary\r\n\r\nFixes Enterprise Search guided onboarding links which broke due to UI\r\nchanges recently.\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1410658/236779703-010884f0-7708-43e0-8f77-e3e0be456452.mov","sha":"e36327c243680ad5695a86fbb038062e1bf34816"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156965","number":156965,"mergeCommit":{"message":"Fix Enterprise Search guide links (#156965)\n\n## Summary\r\n\r\nFixes Enterprise Search guided onboarding links which broke due to UI\r\nchanges recently.\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1410658/236779703-010884f0-7708-43e0-8f77-e3e0be456452.mov","sha":"e36327c243680ad5695a86fbb038062e1bf34816"}}]}] BACKPORT--> Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v8.8.0
v8.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Enterprise Search guided onboarding links which broke due to UI changes recently.
Screen.Recording.2023-05-08.at.10.48.28.mov