Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enterprise Search guide links #156965

Merged
merged 1 commit into from
May 8, 2023

Conversation

efegurkan
Copy link
Member

@efegurkan efegurkan commented May 8, 2023

Summary

Fixes Enterprise Search guided onboarding links which broke due to UI changes recently.

Screen.Recording.2023-05-08.at.10.48.28.mov

@efegurkan efegurkan added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0 labels May 8, 2023
@efegurkan efegurkan requested a review from a team May 8, 2023 08:49
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efegurkan efegurkan enabled auto-merge (squash) May 8, 2023 09:35
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2023
## Summary

Fixes Enterprise Search guided onboarding links which broke due to UI
changes recently.

https://user-images.githubusercontent.com/1410658/236779703-010884f0-7708-43e0-8f77-e3e0be456452.mov
(cherry picked from commit e36327c)
kibanamachine added a commit that referenced this pull request May 8, 2023
# Backport

This will backport the following commits from `main` to `8.8`:
- [Fix Enterprise Search guide links
(#156965)](#156965)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Efe Gürkan
YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T09:51:57Z","message":"Fix
Enterprise Search guide links (#156965)\n\n## Summary\r\n\r\nFixes
Enterprise Search guided onboarding links which broke due to
UI\r\nchanges
recently.\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1410658/236779703-010884f0-7708-43e0-8f77-e3e0be456452.mov","sha":"e36327c243680ad5695a86fbb038062e1bf34816","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156965,"url":"https://github.com/elastic/kibana/pull/156965","mergeCommit":{"message":"Fix
Enterprise Search guide links (#156965)\n\n## Summary\r\n\r\nFixes
Enterprise Search guided onboarding links which broke due to
UI\r\nchanges
recently.\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1410658/236779703-010884f0-7708-43e0-8f77-e3e0be456452.mov","sha":"e36327c243680ad5695a86fbb038062e1bf34816"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156965","number":156965,"mergeCommit":{"message":"Fix
Enterprise Search guide links (#156965)\n\n## Summary\r\n\r\nFixes
Enterprise Search guided onboarding links which broke due to
UI\r\nchanges
recently.\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1410658/236779703-010884f0-7708-43e0-8f77-e3e0be456452.mov","sha":"e36327c243680ad5695a86fbb038062e1bf34816"}}]}]
BACKPORT-->

Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co>
@efegurkan efegurkan deleted the fix-ent-search-guides branch October 26, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants