Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s dashboard] sessions table default columns updated #156951

Merged
merged 4 commits into from
May 8, 2023

Conversation

mitodrummer
Copy link
Contributor

@mitodrummer mitodrummer commented May 8, 2023

Summary

Replaced entry user name with user id. added container

Checklist

Delete any items that are not applicable to this PR.

@mitodrummer mitodrummer requested a review from a team May 8, 2023 03:35
@mitodrummer mitodrummer added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.8.0 Team: Cloud Native Integrations labels May 8, 2023
@mitodrummer mitodrummer requested a review from norrietaylor May 8, 2023 03:35
Copy link
Member

@norrietaylor norrietaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitodrummer mitodrummer enabled auto-merge (squash) May 8, 2023 16:53
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Detections : Page Filters "after each" hook for "Changed banner should hide on Reset"
  • [job] [logs] Security Solution Tests #1 / Detections : Page Filters Changed banner should hide on Reset

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB -201.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mitodrummer mitodrummer merged commit 45afa61 into elastic:main May 8, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2023
## Summary

Replaced entry user name with user id. added container

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

(cherry picked from commit 45afa61)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 8, 2023
#157045)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[k8s dashboard] sessions table default columns updated
(#156951)](#156951)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Karl
Godard","email":"karl.godard@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T18:32:47Z","message":"[k8s
dashboard] sessions table default columns updated (#156951)\n\n##
Summary\r\n\r\nReplaced entry user name with user id. added
container\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"45afa6108b3e62b507afe2c984c81f3154da0df3","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Team:
Cloud Native
Integrations","v8.8.0","v8.9.0"],"number":156951,"url":"https://github.com/elastic/kibana/pull/156951","mergeCommit":{"message":"[k8s
dashboard] sessions table default columns updated (#156951)\n\n##
Summary\r\n\r\nReplaced entry user name with user id. added
container\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"45afa6108b3e62b507afe2c984c81f3154da0df3"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156951","number":156951,"mergeCommit":{"message":"[k8s
dashboard] sessions table default columns updated (#156951)\n\n##
Summary\r\n\r\nReplaced entry user name with user id. added
container\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"45afa6108b3e62b507afe2c984c81f3154da0df3"}}]}]
BACKPORT-->

Co-authored-by: Karl Godard <karl.godard@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants