Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add integration test for epm install on multiple spaces #156864

Merged

Conversation

criamico
Copy link
Contributor

@criamico criamico commented May 5, 2023

Closes #150686

Summary

Add integration test to cover integration installation in multiple spaces

Steps followed:

  • Install System integration
  • Create new space
  • Uninstall System integration
  • Install again in the new space
  • Verify that integration is added successfully, assets are created and tagged with Managed and System tags

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico self-assigned this May 5, 2023
@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels May 5, 2023
@criamico criamico marked this pull request as ready for review May 5, 2023 13:56
@criamico criamico requested a review from a team as a code owner May 5, 2023 13:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico criamico requested a review from juliaElastic May 5, 2023 13:56
@criamico
Copy link
Contributor Author

criamico commented May 5, 2023

@elasticmachine merge upstream

type: 'index-pattern',
id: 'metrics-*',
});
expect(resIndexPatternMetrics.id).equal('metrics-*');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to check that the installed_kibana_space_id is set correctly on the SO. We have seen a support issue recently where this was the problem.

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@criamico
Copy link
Contributor Author

criamico commented May 8, 2023

@elasticmachine merge upstream

@criamico criamico enabled auto-merge (squash) May 8, 2023 12:43
@criamico
Copy link
Contributor Author

criamico commented May 8, 2023

@elasticmachine merge upstream

@criamico criamico merged commit de48b5d into elastic:main May 8, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico deleted the 150686_integration_test_multiple_spaces branch May 8, 2023 14:45
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2023
…tic#156864)

Closes elastic#150686

## Summary

Add integration test to cover integration installation in multiple
spaces

Steps followed:
- Install System integration
- Create new space
- Uninstall System integration
-  Install again in the new space
- Verify that integration is added successfully, assets are created and
tagged with Managed and System tags

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit de48b5d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 8, 2023
…#156864) (#157005)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Fleet] Add integration test for epm install on multiple spaces
(#156864)](#156864)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cristina
Amico","email":"criamico@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-08T14:39:24Z","message":"[Fleet]
Add integration test for epm install on multiple spaces
(#156864)\n\nCloses
https://github.com/elastic/kibana/issues/150686\r\n\r\n##
Summary\r\n\r\nAdd integration test to cover integration installation in
multiple\r\nspaces\r\n\r\nSteps followed:\r\n- Install System
integration\r\n- Create new space\r\n- Uninstall System integration\r\n-
Install again in the new space\r\n- Verify that integration is added
successfully, assets are created and\r\ntagged with Managed and System
tags\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"de48b5d9aca1e41bcd33534844a49bb4efb7754d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.8.0","v8.9.0"],"number":156864,"url":"https://github.com/elastic/kibana/pull/156864","mergeCommit":{"message":"[Fleet]
Add integration test for epm install on multiple spaces
(#156864)\n\nCloses
https://github.com/elastic/kibana/issues/150686\r\n\r\n##
Summary\r\n\r\nAdd integration test to cover integration installation in
multiple\r\nspaces\r\n\r\nSteps followed:\r\n- Install System
integration\r\n- Create new space\r\n- Uninstall System integration\r\n-
Install again in the new space\r\n- Verify that integration is added
successfully, assets are created and\r\ntagged with Managed and System
tags\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"de48b5d9aca1e41bcd33534844a49bb4efb7754d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156864","number":156864,"mergeCommit":{"message":"[Fleet]
Add integration test for epm install on multiple spaces
(#156864)\n\nCloses
https://github.com/elastic/kibana/issues/150686\r\n\r\n##
Summary\r\n\r\nAdd integration test to cover integration installation in
multiple\r\nspaces\r\n\r\nSteps followed:\r\n- Install System
integration\r\n- Create new space\r\n- Uninstall System integration\r\n-
Install again in the new space\r\n- Verify that integration is added
successfully, assets are created and\r\ntagged with Managed and System
tags\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"de48b5d9aca1e41bcd33534844a49bb4efb7754d"}}]}]
BACKPORT-->

Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Add integration tests on install package in multiple spaces
6 participants