[Defend Workflows] Fix osquery tests 8.9 #156850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
tomsonpl
commented
May 8, 2023
| @@ -11,12 +11,14 @@ export const DEFAULT_QUERY = 'select * from processes;'; | |||
| export const BIG_QUERY = 'select * from processes, users limit 110;'; | |||
|
|
|||
| export const selectAllAgents = () => { | |||
| cy.react('AgentsTable').find('input').should('not.be.disabled'); | |||
There was a problem hiding this comment.
I refactored this to stop using cy.react because not everywhere cypress react selector is available (event details flyout).
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @tomsonpl |
patrykkopycinski
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some changes introduced in 8.9 that make our Osquery tests fail. This PR should solve the issues.