Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix content scroll when project side nav enabled #156840

Merged
merged 2 commits into from
May 8, 2023
Merged

fix content scroll when project side nav enabled #156840

merged 2 commits into from
May 8, 2023

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented May 5, 2023

Summary

I think this does this trick:

scroll.mov

@Dosant Dosant added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) labels May 5, 2023
@Dosant Dosant self-assigned this May 5, 2023
@Dosant Dosant marked this pull request as ready for review May 5, 2023 13:38
@Dosant Dosant requested a review from a team as a code owner May 5, 2023 13:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant added the release_note:skip Skip the PR/issue when compiling release notes label May 5, 2023
@Dosant
Copy link
Contributor Author

Dosant commented May 8, 2023

@elasticmachine merge upstream

@Dosant Dosant enabled auto-merge (squash) May 8, 2023 07:49
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 363.5KB 363.5KB +12.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Dosant

@Dosant Dosant merged commit 6df32fd into elastic:main May 8, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

@sphilipse sphilipse sphilipse approved these changes

Assignees

@Dosant Dosant

Labels
backport:skip This commit does not require backporting Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Dosant @elasticmachine @kibana-ci @sebelga @sphilipse @kibanamachine