Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize formatters tests #156835

Merged
merged 4 commits into from
May 8, 2023
Merged

Stabilize formatters tests #156835

merged 4 commits into from
May 8, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented May 5, 2023 •
edited
Loading

Summary

Closes #156153

A small refactoring of the formatters tests to stabilize and unskip them
Build 200 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2227#_

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.9.0 failed-test A test failure on a tracked branch, potentially flaky-test Feature:Lens labels May 6, 2023
@stratoula stratoula marked this pull request as ready for review May 6, 2023 07:25
@stratoula stratoula requested a review from a team as a code owner May 6, 2023 07:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

dej611
dej611 approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@stratoula stratoula merged commit b540825 into elastic:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting failed-test A test failure on a tracked branch, potentially flaky-test Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.9.0
Projects
None yet
Milestone
No milestone
4 participants
@stratoula @kibana-ci @elasticmachine @dej611