Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP] Clean up unused generic #156810

Merged
merged 3 commits into from
May 7, 2023
Merged

[HTTP] Clean up unused generic #156810

merged 3 commits into from
May 7, 2023

Conversation

jloleysens
Copy link
Contributor

Summary

This PR removes an unused generic R from versioned route definitions.

jloleysens
jloleysens commented May 5, 2023
View reviewed changes
packages/core/http/core-http-server/src/versioning/types.ts
handler: (
...params: Parameters<RequestHandler<P, Q, B, Ctx>>
) => MaybePromise<IKibanaResponse<R>>
addVersion<P = unknown, Q = unknown, B = unknown>(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primary change was to remove R from here.

@jloleysens jloleysens added Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels May 5, 2023
@jloleysens jloleysens marked this pull request as ready for review May 5, 2023 10:00
@jloleysens jloleysens requested a review from a team as a code owner May 5, 2023 10:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@jloleysens jloleysens enabled auto-merge (squash) May 5, 2023 10:00
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jloleysens jloleysens merged commit 1abd32c into elastic:main May 7, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 7, 2023
@jloleysens jloleysens deleted the versioned-router/cleanup-types branch May 10, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:http release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jloleysens @elasticmachine @kibana-ci @TinaHeiligers @kibanamachine