[Synthetics] Disable throttling UI configuration for monitor #156798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
shahzad31
commented
May 5, 2023
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
commented
May 5, 2023
jloleysens
approved these changes
May 5, 2023
There was a problem hiding this comment.
Core changes LGTM.
I know this is following a predefined design, but I wonder if using an actual callout component would be cleaner: one with minimal padding/no heading (per the EUI site https://eui.elastic.co/#/display/callout). Perhaps this could be placed below the field label and input field. Just wanted to share the idea, feel free to ignore!
Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
kdelemme
approved these changes
May 8, 2023
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Any counts in public APIs
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 9, 2023
…156798) (#157141) # Backport This will backport the following commits from `main` to `8.8`: - [[Synthetics] Disable throttling UI configuration for monitor (#156798)](#156798) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-05-09T08:49:40Z","message":"[Synthetics] Disable throttling UI configuration for monitor (#156798)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Dominique Clarke <dominique.clarke@elastic.co>\r\nCo-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>","sha":"f0087d7f0b45d26fcd0f93a39e71389c955c675e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.8.0","v8.9.0"],"number":156798,"url":"https://github.com/elastic/kibana/pull/156798","mergeCommit":{"message":"[Synthetics] Disable throttling UI configuration for monitor (#156798)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Dominique Clarke <dominique.clarke@elastic.co>\r\nCo-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>","sha":"f0087d7f0b45d26fcd0f93a39e71389c955c675e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156798","number":156798,"mergeCommit":{"message":"[Synthetics] Disable throttling UI configuration for monitor (#156798)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Dominique Clarke <dominique.clarke@elastic.co>\r\nCo-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>","sha":"f0087d7f0b45d26fcd0f93a39e71389c955c675e"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #156512
Added a help-text to inform user about why it's disabled. Link will lead to notice in synthetics repo.
For testing and dev purpose adding a ui setting which can be used to enable throttling ui configuration.
via key in kibana config
uiSettings.overrides.observability:syntheticsThrottlingEnabled: trueor via UI
Release note
Network throttling has temporarily been disabled for browser based Synthetics monitors with the 8.8.0 release. This will be enabled at some point in the future. The latest status can be found here.