[RAM][SECURITYSOLUTION][ALERTS] - Throw an error when user tries to set schedule interval shorter than any action frequency #156644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…any action frequency
|
Pinging @elastic/response-ops (Team:ResponseOps) |
XavierM
reviewed
May 5, 2023
|
|
||
| if (actionsWithInvalidThrottles.length > 0) { | ||
| throw Error( | ||
| `Error updating rule: the interval is longer than the action frequencies: ${actionsWithInvalidThrottles |
There was a problem hiding this comment.
Can we just add the ruleId and/or the ruleName in the error?
There was a problem hiding this comment.
ah yeah, that would be more useful!
|
@elasticmachine merge upstream |
XavierM
approved these changes
May 5, 2023
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @e40pud |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 5, 2023
…et schedule interval shorter than any action frequency (elastic#156644) ## Summary These changes insure that alerting framework throws an exception when user tries to set rule's schedule interval shorter than one of the action frequencies. The message will look like: `"message": "Error updating rule: the interval is longer than the action frequencies: 1h"` TheUI changes will be addressed in the 8.9 in this ticket elastic#155502 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e1ee019)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 5, 2023
…s to set schedule interval shorter than any action frequency (#156644) (#156920) # Backport This will backport the following commits from `main` to `8.8`: - [[RAM][SECURITYSOLUTION][ALERTS] - Throw an error when user tries to set schedule interval shorter than any action frequency (#156644)](#156644) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-05-05T20:46:31Z","message":"[RAM][SECURITYSOLUTION][ALERTS] - Throw an error when user tries to set schedule interval shorter than any action frequency (#156644)\n\n## Summary\r\n\r\nThese changes insure that alerting framework throws an exception when\r\nuser tries to set rule's schedule interval shorter than one of the\r\naction frequencies.\r\n\r\nThe message will look like:\r\n\r\n`\"message\": \"Error updating rule: the interval is longer than the action\r\nfrequencies: 1h\"`\r\n\r\nTheUI changes will be addressed in the 8.9 in this ticket\r\nhttps://github.com//issues/155502\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e1ee0196653a38fc6b7f8abfb191a286ad020176","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Team:Detection Alerts","backport:prev-minor","ci:cloud-deploy","v8.9.0"],"number":156644,"url":"https://github.com/elastic/kibana/pull/156644","mergeCommit":{"message":"[RAM][SECURITYSOLUTION][ALERTS] - Throw an error when user tries to set schedule interval shorter than any action frequency (#156644)\n\n## Summary\r\n\r\nThese changes insure that alerting framework throws an exception when\r\nuser tries to set rule's schedule interval shorter than one of the\r\naction frequencies.\r\n\r\nThe message will look like:\r\n\r\n`\"message\": \"Error updating rule: the interval is longer than the action\r\nfrequencies: 1h\"`\r\n\r\nTheUI changes will be addressed in the 8.9 in this ticket\r\nhttps://github.com//issues/155502\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e1ee0196653a38fc6b7f8abfb191a286ad020176"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156644","number":156644,"mergeCommit":{"message":"[RAM][SECURITYSOLUTION][ALERTS] - Throw an error when user tries to set schedule interval shorter than any action frequency (#156644)\n\n## Summary\r\n\r\nThese changes insure that alerting framework throws an exception when\r\nuser tries to set rule's schedule interval shorter than one of the\r\naction frequencies.\r\n\r\nThe message will look like:\r\n\r\n`\"message\": \"Error updating rule: the interval is longer than the action\r\nfrequencies: 1h\"`\r\n\r\nTheUI changes will be addressed in the 8.9 in this ticket\r\nhttps://github.com//issues/155502\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e1ee0196653a38fc6b7f8abfb191a286ad020176"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes insure that alerting framework throws an exception when user tries to set rule's schedule interval shorter than one of the action frequencies.
The message will look like:
"message": "Error updating rule: the interval is longer than the action frequencies: 1h"The UI changes will be addressed in the 8.9 in this ticket #155502