Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mobile API tests #156578

Merged
merged 12 commits into from
May 16, 2023
Merged

Improve mobile API tests #156578

merged 12 commits into from
May 16, 2023

Conversation

MiriamAparicio
Copy link
Contributor

There were some comments regarding the api test done for the mobile transactions main and detailed statistics as part of this PR

Summary

  • add value specific test not just check if the response is empty (detailed statistics timeseries test)
  • calculate values based on the inputs for generating data, instead of like snapshot testing (throughput)

This PR also contains the fixes for the following failing skipped tests

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@MiriamAparicio MiriamAparicio force-pushed the improve-mobile-api-tests branch from 33341ae to bd3d9d4 Compare May 8, 2023 10:16
@MiriamAparicio MiriamAparicio added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture v8.9.0 release_note:skip Skip the PR/issue when compiling release notes labels May 8, 2023
@MiriamAparicio MiriamAparicio marked this pull request as ready for review May 8, 2023 10:18
@MiriamAparicio MiriamAparicio requested a review from a team as a code owner May 8, 2023 10:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

sorenlouv
sorenlouv approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for fixing

@MiriamAparicio MiriamAparicio force-pushed the improve-mobile-api-tests branch from 816b636 to 41ea0bc Compare May 9, 2023 09:53
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 9, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #16 / dashboard Reporting Dashboard Reporting Screenshots Preserve Layout downloads a PDF file: large dashboard
  • [job] [logs] FTR Configs #16 / dashboard Reporting Dashboard Reporting Screenshots Preserve Layout downloads a PDF file: large dashboard
  • [job] [logs] FTR Configs #39 / Interactive Setup Functional Tests (Manual configuration without TLS) should configure Kibana successfully
  • [job] [logs] FTR Configs #39 / Interactive Setup Functional Tests (Manual configuration without TLS) should configure Kibana successfully
  • [job] [logs] FTR Configs #36 / Interactive Setup Functional Tests (Manual configuration) should configure Kibana successfully
  • [job] [logs] FTR Configs #36 / Interactive Setup Functional Tests (Manual configuration) should configure Kibana successfully

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

  • 💚 Build #126141 succeeded 816b636d85538a5554c84d01451cd19d4ff61e82
  • 💛 Build #125242 was flaky 33341ae928ab75c1d3e6c287e4e049075fd385bb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MiriamAparicio MiriamAparicio force-pushed the improve-mobile-api-tests branch from 97c326c to 04a3db5 Compare May 10, 2023 08:47
dgieselaar
dgieselaar approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just some nits about sorting results before asserting whether they are equal.

@MiriamAparicio MiriamAparicio force-pushed the improve-mobile-api-tests branch 2 times, most recently from bb1980d to 7769951 Compare May 10, 2023 14:37
@MiriamAparicio MiriamAparicio enabled auto-merge (squash) May 10, 2023 14:53
@MiriamAparicio MiriamAparicio force-pushed the improve-mobile-api-tests branch from e15aac2 to 2830246 Compare May 11, 2023 07:29
@MiriamAparicio MiriamAparicio force-pushed the improve-mobile-api-tests branch from 4d279f0 to 59493f8 Compare May 11, 2023 07:31
@MiriamAparicio MiriamAparicio force-pushed the improve-mobile-api-tests branch 2 times, most recently from 6572cbb to 681ba0e Compare May 16, 2023 13:52
@MiriamAparicio MiriamAparicio force-pushed the improve-mobile-api-tests branch from 1a3c4e6 to 3c4338f Compare May 16, 2023 15:23
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

  • 💔 Build #128223 failed 1a3c4e69d30f453f6133e3b3950c999c38f4fd8e
  • 💔 Build #128196 failed 6572cbbccdf6acc46dbf9621745dfe6cf4c35288
  • 💔 Build #127994 failed 4680317bc6dc709dcc403b9981043bffcb23cda2
  • 💔 Build #127918 failed f8995451999239aa61fc00f0794f0d12e1a76138
  • 💔 Build #127670 failed fc4322916f8359d07cfae49ea1dd28ec142f4d4f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MiriamAparicio MiriamAparicio merged commit b35265b into elastic:main May 16, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2023
@MiriamAparicio MiriamAparicio deleted the improve-mobile-api-tests branch May 17, 2023 07:19
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
@MiriamAparicio @jasonrhodes
Improve mobile API tests (#156578)
a3bb8f1 
There were some comments regarding the api test done for the mobile
transactions main and detailed statistics as part of this
[PR](#153044)

### Summary
- add value specific test not just check if the response is empty
(detailed statistics timeseries test)
- calculate values based on the inputs for generating data, instead of
like snapshot testing (throughput)

This PR also contains the fixes for the following failing skipped tests 
- #156207
- #156218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MiriamAparicio @apmmachine @elasticmachine @kibana-ci @sorenlouv @dgieselaar @kibanamachine