[Synthetics] adjust run_from.id for private locations #156324

dominiqueclarke · 2023-05-02T00:00:42Z

Release Note

All Synthetics errors that are in-progress for private locations at the time the stack is upgrading will be resolved. A new error state will take its place.

Summary

Resolves #156320

Adjust the value of the run_from.id field.

Before
Both the run_from.id and the run_from.name were the same value.

After

Testing

Check out this PR from integrations [Synthetics] adjust run_from.id integrations#6047
In the integrations repo cd packages/synthetics
Run elastic-package clean then elastic-package build (You may need to upgrade elastic package if you're significantly behind)
In your kibana.dev.yml file add xpack.fleet.registryUrl: https://localhost:8080
Start kibana with NODE_EXTRA_CA_CERTS=$HOME/.elastic-package/profiles/default/certs/kibana/ca-cert.pem yarn start --no-base-path
Create a private location
Create a monitor assigned to that private location
Inspect the agent policy for that private location, then find the integration policy for that monitor. Ensure the run_from.id is the id of the location, and the run_from.name is the name of the location.

(If you run into problems setting up your local kibana connected to elastic-package registry, see https://github.com/elastic/security-team/blob/main/docs/cloud-security-posture-team/kibana/local-setup-using-elastic-package.mdx)

apmmachine · 2023-05-02T00:00:57Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-05-02T12:45:50Z

Pinging @elastic/uptime (Team:uptime)

elasticmachine · 2023-05-11T06:25:16Z

Pinging @elastic/fleet (Team:Fleet)

dominiqueclarke · 2023-05-11T14:30:39Z

x-pack/plugins/fleet/server/saved_objects/migrations/synthetics/to_v8_8_0.ts

@@ -66,6 +68,12 @@ export const migratePackagePolicyToV880: SavedObjectMigrationFn<PackagePolicy, P
    }
  }

+  // set location_id.id to agentPolicyId
+  if (enabledStream.vars && enabledStream.vars.location_id) {


This var doesn't yet exist in existing policies, so this condition will never be satisfied. We need to manually add on the new variable.

dominiqueclarke · 2023-05-11T14:31:20Z

x-pack/plugins/fleet/server/saved_objects/migrations/synthetics/to_v8_8_0.ts

@@ -66,6 +68,12 @@ export const migratePackagePolicyToV880: SavedObjectMigrationFn<PackagePolicy, P
    }
  }

+  // set location_id.id to agentPolicyId
+  if (enabledStream.vars && enabledStream.vars.location_id) {
+    enabledStream.vars.location_id.value = agentPolicyId;


So this var doesn't yet exist, but will in the version of the policy that will be shipped with 8.8.0. Because of that, we may want to also add in the type?

enabledStream.vars.location_id = { type: 'text', value: agentPolicyId };

I'm not sure if creating a brand new variable that doesn't yet exist causes issues, @kpollich

dominiqueclarke · 2023-05-11T14:31:36Z

x-pack/plugins/fleet/server/saved_objects/migrations/synthetics/fixtures/8.7.0.ts

@@ -64,6 +64,7 @@ export const httpPolicy = {
              'ssl.verification_mode': { value: null, type: 'text' },
              'ssl.supported_protocols': { value: null, type: 'yaml' },
              location_name: { value: 'A private location', type: 'text' },
+              location_id: { value: 'A private location', type: 'text' },


Remove this. This does not exist in the current policies. It's a bad fixture.

…run-from-id

nchaulet

Fleet migration 🚀

kibana-ci · 2023-05-11T20:15:42Z

💚 Build Succeeded

Buildkite Build
Commit: 464c507

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`synthetics`	1.2MB	1.2MB	+35.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	400	404	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	480	484	+4
total			+6

History

💚 Build #127026 succeeded f8d2c46
💛 Build #126968 was flaky 8562115
💛 Build #124656 was flaky 6c692f3
💔 Build #124651 failed f93654c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

## Summary Resolves elastic#156320 Adjust the value of the `run_from.id` field. Before Both the `run_from.id` and the `run_from.name` were the same value. After <img width="543" alt="Screen Shot 2023-05-01 at 7 55 24 PM" src="https://user-images.githubusercontent.com/11356435/235551964-bb9c419d-2ada-4a39-bd08-ce6f5021747b.png"> ### Testing 1. Check out this PR from integrations elastic/integrations#6047 2. In the integrations repo `cd packages/synthetics` 3. Run `elastic-package clean` then `elastic-package build` (You may need to upgrade elastic package if you're significantly behind) 4. In your `kibana.dev.yml` file add `xpack.fleet.registryUrl: https://localhost:8080` 5. Start kibana with `NODE_EXTRA_CA_CERTS=$HOME/.elastic-package/profiles/default/certs/kibana/ca-cert.pem yarn start --no-base-path` 6. Create a private location 7. Create a monitor assigned to that private location 8. Inspect the agent policy for that private location, then find the integration policy for that monitor. Ensure the `run_from.id` is the id of the location, and the `run_from.name` is the name of the location. (If you run into problems setting up your local kibana connected to elastic-package registry, see https://github.com/elastic/security-team/blob/main/docs/cloud-security-posture-team/kibana/local-setup-using-elastic-package.mdx) --------- Co-authored-by: shahzad31 <shahzad31comp@gmail.com> (cherry picked from commit f59471b)

kibanamachine · 2023-05-12T18:37:24Z

💚 All backports created successfully

Status	Branch	Result
✅	8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…#157531) # Backport This will backport the following commits from `main` to `8.8`: - [[Synthetics] adjust run_from.id for private locations (#156324)](#156324)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co> Co-authored-by: Shahzad <shahzad31comp@gmail.com>

## Summary Resolves #156320 Adjust the value of the `run_from.id` field. Before Both the `run_from.id` and the `run_from.name` were the same value. After <img width="543" alt="Screen Shot 2023-05-01 at 7 55 24 PM" src="https://user-images.githubusercontent.com/11356435/235551964-bb9c419d-2ada-4a39-bd08-ce6f5021747b.png"> ### Testing 1. Check out this PR from integrations elastic/integrations#6047 2. In the integrations repo `cd packages/synthetics` 3. Run `elastic-package clean` then `elastic-package build` (You may need to upgrade elastic package if you're significantly behind) 4. In your `kibana.dev.yml` file add `xpack.fleet.registryUrl: https://localhost:8080` 5. Start kibana with `NODE_EXTRA_CA_CERTS=$HOME/.elastic-package/profiles/default/certs/kibana/ca-cert.pem yarn start --no-base-path` 6. Create a private location 7. Create a monitor assigned to that private location 8. Inspect the agent policy for that private location, then find the integration policy for that monitor. Ensure the `run_from.id` is the id of the location, and the `run_from.name` is the name of the location. (If you run into problems setting up your local kibana connected to elastic-package registry, see https://github.com/elastic/security-team/blob/main/docs/cloud-security-posture-team/kibana/local-setup-using-elastic-package.mdx) --------- Co-authored-by: shahzad31 <shahzad31comp@gmail.com>

synthetics - adjust run_from.id for private locations

f93654c

Merge branch 'main' into fix/synthetics-run-from-id

6c692f3

dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0 v8.9.0 release_note:skip Skip the PR/issue when compiling release notes labels May 2, 2023

dominiqueclarke marked this pull request as ready for review May 2, 2023 12:45

dominiqueclarke requested a review from a team as a code owner May 2, 2023 12:45

shahzad31 approved these changes May 3, 2023

View reviewed changes

dominiqueclarke closed this May 4, 2023

dominiqueclarke reopened this May 10, 2023

dominiqueclarke and others added 2 commits May 10, 2023 15:20

Merge branch 'main' into fix/synthetics-run-from-id

8562115

add migration

f8d2c46

shahzad31 requested a review from a team as a code owner May 11, 2023 06:25

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 11, 2023

dominiqueclarke commented May 11, 2023

View reviewed changes

shahzad31 added 2 commits May 11, 2023 20:55

Merge branch 'main' of github.com:elastic/kibana into fix/synthetics-…

b2e59a2

…run-from-id

update migration

464c507

nchaulet approved these changes May 11, 2023

View reviewed changes

dominiqueclarke merged commit f59471b into elastic:main May 12, 2023

dominiqueclarke deleted the fix/synthetics-run-from-id branch May 12, 2023 18:30

dominiqueclarke added release_note:breaking and removed release_note:skip Skip the PR/issue when compiling release notes labels May 12, 2023

kibanamachine mentioned this pull request May 12, 2023

[8.8] [Synthetics] adjust run_from.id for private locations (#156324) #157531

Merged

dokmic mentioned this pull request Jul 28, 2023

Failing test: Execution Context Functional Tests.x-pack/test/functional_execution_context/tests/server·ts - Execution context Server-side apps propagates context for Task and Alerts #157565

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Synthetics] adjust run_from.id for private locations #156324

[Synthetics] adjust run_from.id for private locations #156324

dominiqueclarke commented May 2, 2023 •

edited

Loading

apmmachine commented May 2, 2023

elasticmachine commented May 2, 2023

elasticmachine commented May 11, 2023

dominiqueclarke May 11, 2023

dominiqueclarke May 11, 2023

dominiqueclarke May 11, 2023

nchaulet left a comment

kibana-ci commented May 11, 2023

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented May 12, 2023

[Synthetics] adjust run_from.id for private locations #156324

[Synthetics] adjust run_from.id for private locations #156324

Conversation

dominiqueclarke commented May 2, 2023 • edited Loading

Release Note

Summary

Testing

apmmachine commented May 2, 2023

🤖 GitHub comments

elasticmachine commented May 2, 2023

elasticmachine commented May 11, 2023

dominiqueclarke May 11, 2023

Choose a reason for hiding this comment

dominiqueclarke May 11, 2023

Choose a reason for hiding this comment

dominiqueclarke May 11, 2023

Choose a reason for hiding this comment

nchaulet left a comment

Choose a reason for hiding this comment

kibana-ci commented May 11, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented May 12, 2023

💚 All backports created successfully

Questions ?

dominiqueclarke commented May 2, 2023 •

edited

Loading