Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security][Fleet] Deployment instructions update for CSP Integrations #155476

Merged
merged 12 commits into from
May 18, 2023
Merged

[Cloud Security][Fleet] Deployment instructions update for CSP Integrations #155476

merged 12 commits into from
May 18, 2023

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Apr 21, 2023 •
edited
Loading

Summary

This PR is for updating the Deployment instructions when trying to add agent to CSP integration.
Previously we were using isK8sPackage ref, but it seems to be very dedicated for kubernetes integration and this seems to be causing an issue when showing prompts such as the one listed on this ticket #151701

This PR created another function that handles this for CSP integration while not affecting how isK8sPackage affecting other integrations

TODO:

  • Add new prompt message for CSPM under Mac tab option

Definition of done

  • Undo kspm effect on showing the mentioned prompt above
  • Show/Select k8s deployment method when kspm is part of the agent policy
  • Warn when cloudbeat doesn't support/suggest to use specific deployment (examples: using k8s deployment when running cspm or deploying cloudbeat on darwin)

screen_shot_2023-04-20_at_11 35 18_pm

@animehart animehart requested a review from kfirpeled April 21, 2023 06:43
@animehart animehart linked an issue Apr 21, 2023 that may be closed by this pull request
Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/doc_level_security_roles·ts - security app dls "after all" hook: logout for "user East should only see EAST doc" #155448
Closed
@animehart animehart removed a link to an issue Apr 21, 2023
Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/doc_level_security_roles·ts - security app dls "after all" hook: logout for "user East should only see EAST doc" #155448
Closed
@animehart animehart linked an issue Apr 21, 2023 that may be closed by this pull request
[Cloud Security] Fix deployment instructions #151701
Closed
3 tasks
@kfirpeled kfirpeled added v8.9.0 Team:Cloud Security Cloud Security team related release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Apr 23, 2023
kfirpeled
kfirpeled reviewed Apr 23, 2023
View reviewed changes
Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks we are heading in the right direction 👍

@animehart animehart marked this pull request as ready for review May 15, 2023 23:43
@animehart animehart requested a review from a team as a code owner May 15, 2023 23:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@Omolola-Akinleye Omolola-Akinleye self-requested a review May 16, 2023 20:16
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

opauloh
opauloh requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments to improve readability, I'll be happy to sync on the changes if needed

@animehart animehart requested a review from opauloh May 17, 2023 08:17
@Omolola-Akinleye
Copy link
Contributor

Looking good! Thanks for the changes. Once the build is fixed. I'll approve the PR.

kpollich
kpollich approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the Fleet side

opauloh
opauloh requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one more change and also fix the CI

@animehart animehart requested a review from opauloh May 17, 2023 17:13
opauloh
opauloh approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Fleet Cypress Tests / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1013 1015 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 965.0KB 966.9KB +1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 128.2KB 129.2KB +975.0B
Unknown metric groups

API count

id before after diff
fleet 1118 1120 +2

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@animehart animehart merged commit fc5a39a into elastic:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled left review comments

@kpollich kpollich kpollich approved these changes

@Omolola-Akinleye Omolola-Akinleye Omolola-Akinleye approved these changes

@opauloh opauloh opauloh approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related Team:Fleet Team label for Observability Data Collection Fleet team v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Security] Fix deployment instructions
8 participants
@animehart @elasticmachine @Omolola-Akinleye @kibana-ci @kpollich @opauloh @kfirpeled @kibanamachine