Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Remove index false from artifact saved objects mappings #155204

Merged
merged 12 commits into from
Apr 25, 2023
+49 −336
Merged

[Security Solution] Remove index false from artifact saved objects mappings #155204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
15daa0f
[Security Solution] Remove index false from artifact saved objects ma…
kevinlog Apr 18, 2023
891b39f
update snapshot
kevinlog Apr 18, 2023
19d06c7
delete unused SO
kevinlog Apr 19, 2023
3af7d62
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Apr 19, 2023
13edaf3
remove fields that were not indexed
kevinlog Apr 19, 2023
1068f4d
Merge branch 'task/remove-enabled-index-false-fields' of github.com:k…
kevinlog Apr 19, 2023
0ea2a73
remove last field
kevinlog Apr 19, 2023
efdd7b1
fix test
kevinlog Apr 19, 2023
e95a49f
fix tests
kevinlog Apr 19, 2023
8230f87
actually fix tests
kevinlog Apr 20, 2023
1aad7c0
Merge branch 'main' into task/remove-enabled-index-false-fields
gsoldevila Apr 25, 2023
85395d5
update after kibana index split
kevinlog Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions ...-migration-server-internal/src/__snapshots__/migrations_state_action_machine.test.ts.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions .../core/saved-objects/core-saved-objects-migration-server-internal/src/core/unused_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ export const REMOVED_TYPES: string[] = [
'csp_rule',
// Removed in 8.8 https://github.com/elastic/kibana/pull/151116
'upgrade-assistant-telemetry',
// Removed in 8.8 https://github.com/elastic/kibana/pull/155204
'endpoint:user-artifact',
].sort();

export const excludeUnusedTypesQuery: QueryDslQueryContainer = {
Expand Down
5 changes: 5 additions & 0 deletions ...core/saved-objects/core-saved-objects-migration-server-internal/src/initial_state.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ describe('createInitialState', () => {
"type": "csp_rule",
},
},
Object {
"term": Object {
"type": "endpoint:user-artifact",
},
},
Object {
"term": Object {
"type": "file-upload-telemetry",
Expand Down
3 changes: 1 addition & 2 deletions ...e/server/integration_tests/saved_objects/migrations/group2/check_registered_types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@ describe('checking migration metadata changes on all registered SO types', () =>
"core-usage-stats": "b3c04da317c957741ebcdedfea4524049fdc79ff",
"csp-rule-template": "099c229bf97578d9ca72b3a672d397559b84ee0b",
"dashboard": "71e3f8dfcffeb5fbd410dec81ce46f5691763c43",
"endpoint:user-artifact": "a5b154962fb6cdf5d9e7452e58690054c95cc72a",
"endpoint:user-artifact-manifest": "5989989c0f84dd2d02da1eb46b6254e334bd2ccd",
"endpoint:user-artifact-manifest": "8ad9bd235dcfdc18b567aef0dc36ac686193dc89",
"enterprise_search_telemetry": "4b41830e3b28a16eb92dee0736b44ae6276ced9b",
"epm-packages": "8755f947a00613f994b1bc5d5580e104043e27f6",
"epm-packages-assets": "00c8b5e5bf059627ffc9fbde920e1ac75926c5f6",
Expand Down
1 change: 0 additions & 1 deletion src/core/server/integration_tests/saved_objects/migrations/group3/split_kibana_index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ describe('split .kibana index into multiple system indices', () => {
"connector_token",
"core-usage-stats",
"csp-rule-template",
"endpoint:user-artifact",
"endpoint:user-artifact-manifest",
"enterprise_search_telemetry",
"epm-packages",
Expand Down
2 changes: 0 additions & 2 deletions test/api_integration/fixtures/es_archiver/saved_objects/delete_unknown_types/mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
],
".kibana_security_solution": [
"csp-rule-template",
"endpoint:user-artifact",
"endpoint:user-artifact-manifest",
"exception-list",
"exception-list-agnostic",
Expand Down Expand Up @@ -750,7 +749,6 @@
],
".kibana_security_solution": [
"csp-rule-template",
"endpoint:user-artifact",
"endpoint:user-artifact-manifest",
"exception-list",
"exception-list-agnostic",
Expand Down
1 change: 0 additions & 1 deletion test/functional/fixtures/es_archiver/deprecations_service/mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
],
".kibana_security_solution": [
"csp-rule-template",
"endpoint:user-artifact",
"endpoint:user-artifact-manifest",
"exception-list",
"exception-list-agnostic",
Expand Down
1 change: 0 additions & 1 deletion test/functional/fixtures/es_archiver/saved_objects_management/export_transform/mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
],
".kibana_security_solution": [
"csp-rule-template",
"endpoint:user-artifact",
"endpoint:user-artifact-manifest",
"exception-list",
"exception-list-agnostic",
Expand Down
1 change: 0 additions & 1 deletion ...nctional/fixtures/es_archiver/saved_objects_management/hidden_saved_objects/mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
],
".kibana_security_solution": [
"csp-rule-template",
"endpoint:user-artifact",
"endpoint:user-artifact-manifest",
"exception-list",
"exception-list-agnostic",
Expand Down
1 change: 0 additions & 1 deletion ...ional/fixtures/es_archiver/saved_objects_management/nested_export_transform/mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
],
".kibana_security_solution": [
"csp-rule-template",
"endpoint:user-artifact",
"endpoint:user-artifact-manifest",
"exception-list",
"exception-list-agnostic",
Expand Down
2 changes: 0 additions & 2 deletions ...ctional/fixtures/es_archiver/saved_objects_management/visible_in_management/mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
],
".kibana_security_solution": [
"csp-rule-template",
"endpoint:user-artifact",
"endpoint:user-artifact-manifest",
"exception-list",
"exception-list-agnostic",
Expand Down Expand Up @@ -696,7 +695,6 @@
],
".kibana_security_solution": [
"csp-rule-template",
"endpoint:user-artifact",
"endpoint:user-artifact-manifest",
"exception-list",
"exception-list-agnostic",
Expand Down
144 changes: 0 additions & 144 deletions ...lugins/security_solution/server/endpoint/lib/artifacts/migrate_artifacts_to_fleet.test.ts
View file
Open in desktop

This file was deleted.

Loading