[Telemetry] Use soClient in FTRs
#155175
Merged
[Telemetry] Use soClient in FTRs
#155175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
commented
Apr 18, 2023
There was a problem hiding this comment.
Removed because it's a duplicate to test/api_integration/apis/telemetry/opt_in.ts and there's no different behaviour in X-Pack
There was a problem hiding this comment.
Removed because it's a duplicate to test/api_integration/apis/telemetry/telemetry_optin_notice_seen.ts and there's no different behaviour in X-Pack
Comment on lines
+122
to
+124
| if (err.response?.status === 404) { | ||
| return {}; | ||
| } |
There was a problem hiding this comment.
This is the hardest part of our SO client... handling 404s... 😜
|
Pinging @elastic/kibana-core (Team:Core) |
gsoldevila
reviewed
Apr 18, 2023
|
|
||
| import { TelemetrySavedObjectAttributes } from '@kbn/telemetry-plugin/server/saved_objects'; | ||
| import SuperTest from 'supertest'; | ||
| import { KbnClient } from '@kbn/test'; |
There was a problem hiding this comment.
NIT can be imported as a type
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @afharo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the Saved Objects client in the FTRs instead of writing to
.kibanavia ES client.Doing it now because it facilitates the efforts in #154888
Checklist
For maintainers