[AO] Add evaluation values for metric threshold and inventory rules #154255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
maryam-saeidi
commented
Apr 3, 2023
.../infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts
Outdated
Show resolved
Hide resolved
maryam-saeidi
commented
Apr 6, 2023
| @@ -77,7 +77,7 @@ type CastSingle<T extends t.Type<any>> = t.Type< | |||
| >; | |||
|
|
|||
| const createCastArrayRt = <T extends t.Type<any>>(type: T): CastArray<T> => { | |||
| const union = t.union([type, t.array(type)]); | |||
| const union = t.union([type, t.array(t.union([type, t.nullType]))]); | |||
There was a problem hiding this comment.
This change is related to the values that are saved in kibana.alert.evaluation.values, it is a mixture of the specified type (scaled_float) and null
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
simianhacker
approved these changes
Apr 6, 2023
mohamedhamed-ahmed
approved these changes
Apr 20, 2023
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153877
Summary
This PR adds a new field called
kibana.alert.evaluation.valuesto the alert document for metric threshold and inventory rules. This is an array of numbers but depending on the result of the rule execution, the value might benulltoo.We want to use this result in the metric threshold alert details page, so I checked whether this value can be retrieved correctly there or not:
Note
I will add tests later, I would like to get feedback about the implementation first.
🧪 How to test
kibana.alert.evaluation.valuesfield, it should be an array with the result of evaluation for the related criteriakibana.alert.evaluation.valuesfield, it should be an array including a null value