Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Osquery] Remove osquery-manager-usage-metric SO type #154100

Merged
merged 16 commits into from
May 23, 2023
Merged

[Osquery] Remove osquery-manager-usage-metric SO type #154100

merged 16 commits into from
May 23, 2023

Conversation

patrykkopycinski
Copy link
Contributor

Summary

Remove unused osquery-manager-usage-metric SO type

@patrykkopycinski patrykkopycinski marked this pull request as ready for review March 31, 2023 14:14
@patrykkopycinski patrykkopycinski requested review from a team as code owners March 31, 2023 14:14
@patrykkopycinski patrykkopycinski added chore release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Mar 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

gergoabraham
gergoabraham reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understood, this looks thorough 🚀

but how come that osquery-manager-usage-metric is unused? I see it is (was) used by the usage collector which is also removed - but it didn't look like dead code, how is it unused?

...ges/core/saved-objects/core-saved-objects-migration-server-internal/src/core/unused_types.ts Outdated
@@ -29,6 +29,8 @@ export const REMOVED_TYPES: string[] = [
'server',
// https://github.com/elastic/kibana/issues/95617
'tsvb-validation-telemetry',
// Was removed in 8.8 https://github.com/elastic/kibana/issues/223232
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the url returns 404

afharo
afharo approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM

tomsonpl
tomsonpl approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
osquery 108 106 -2
securitySolution 399 403 +4
total +4

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
osquery 109 107 -2
securitySolution 479 483 +4
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 7a62628 into elastic:main May 23, 2023
@patrykkopycinski patrykkopycinski deleted the chore/remove-osquery-usage-so branch May 23, 2023 11:42
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 23, 2023
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
@patrykkopycinski @kibanamachine @delanni
[Osquery] Remove osquery-manager-usage-metric SO type (elastic#154100)
53eb20d 
## Summary

Remove unused `osquery-manager-usage-metric` SO type

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gergoabraham gergoabraham gergoabraham left review comments

@afharo afharo afharo approved these changes

@tomsonpl tomsonpl tomsonpl approved these changes

@dasansol92 dasansol92 Awaiting requested review from dasansol92 dasansol92 is a code owner automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@patrykkopycinski @elasticmachine @kibana-ci @afharo @tomsonpl @gergoabraham @kibanamachine