-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slo): Add timestampField additional settings #153395
feat(slo): Add timestampField additional settings #153395
Conversation
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works as expected. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SO mapping changes LGTM
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Saved Objects .kibana field count
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @kdelemme |
Summary
Resolves #153397
This PR adds the timestampField's additional settings in the create/edit SLO form.
While working on this, I noticed that we were using the
settings.timestampField
in all transforms, with a@timestamp
default value if not provided.This could lead to potential issue as APM data are always ingested using
@timestamp
field, therefore, thetimestampField
needed to become a custom KQL indicator specificities, and should not be overridable for APM indicator types.Therefore, I've moved the
settings.timestampField
to the custom KQLindicator.params
as an optional field. When not provided, or empty (""
), the transform uses@timestamp
.APM transforms have been changed to always use
@timestamp
.Finally, I've updated the OpenAPI documentation as well as the dev docs.
🧪 Manual testing
From the API
my_timestamp
fieldFrom the UI
Create a custom KQL SLO and override (and not) the timestampField under the additional settings.
@timestamp
when not overridden