Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maps shoukld offer tsdb counter fields only when its supported by es #152899

Merged
merged 2 commits into from
Mar 9, 2023
Merged

maps shoukld offer tsdb counter fields only when its supported by es #152899

merged 2 commits into from
Mar 9, 2023

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Mar 8, 2023

Summary

Updates maps application so that field dropdown only offers tsdb counter metric fields in combination with aggregations that are supported on such field

@ppisljar ppisljar marked this pull request as ready for review March 8, 2023 11:46
@ppisljar ppisljar requested a review from a team as a code owner March 8, 2023 11:46
@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.8.0 labels Mar 8, 2023
@ppisljar ppisljar mentioned this pull request Mar 8, 2023
Merged
4 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +61.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 505 507 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck mentioned this pull request Mar 8, 2023
Closed
@nreese nreese self-requested a review March 8, 2023 15:22
nreese
nreese approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for updating maps application
code review

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps labels Mar 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ppisljar ppisljar merged commit 48b3b90 into elastic:main Mar 9, 2023
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@ppisljar @bmorelli25
maps shoukld offer tsdb counter fields only when its supported by es (e…
0c086b0 
…lastic#152899)
@stratoula stratoula mentioned this pull request Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Maps release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppisljar @kibana-ci @elasticmachine @nreese