[Synthetics] Private location better error handling #152695

shahzad31 · 2023-03-06T10:26:25Z

Private location better error handling, error handling has been done to make sure, if somehow creating package policy fails, it properly reflects in the UI and also for project monitors

Testing Scope

Since these PR touches lot of public/private location code paths, following test should be performed

UI Monitors

Creating monitor in on self hosted and on cloud
Editing monitor with multiple locations in self hosted and on
Test that if creating/editing integration fails, it shows error in the UI

Project monitors

Add/edit/delete single project monitors
Add/edit/delete multiple project monitors
Add multiple monitors but one of the should fail with some error
Edit multiple monitors but one of them should fail with error

…ndling

dominiqueclarke

An internal server error happens during the editing flow

<img width="798" alt="Screen Shot 2023-05-02 at 9 08 28 PM" src="https://user-images.githubusercontent.com/11356435/235816127-92f79d9e-e77c-4329-a7e7-4bf0bca79652.png">

dominiqueclarke

After removing the routeContext issue with a commit I pushed, I'm seeing this issue on the edit monitor flow.

proc [kibana] [2023-05-02T21:32:15.814-04:00][ERROR][http] ResponseError: [1:360] [bool] failed to parse field [filter]: x_content_parse_exception
 proc [kibana]  Caused by:
 proc [kibana]          x_content_parse_exception: [1:360] [bool] failed to parse field [should]
 proc [kibana]  Root causes:
 proc [kibana]          parsing_exception: [terms] query does not support [namespaces]
 proc [kibana]     at KibanaTransport.request (/Users/dominiqueclarke/dev/kibana/node_modules/@elastic/transport/src/Transport.ts:535:17)
 proc [kibana]     at runMicrotasks (<anonymous>)
 proc [kibana]     at processTicksAndRejections (node:internal/process/task_queues:96:5)

…ndling

elasticmachine · 2023-05-03T16:40:55Z

Pinging @elastic/fleet (Team:Fleet)

elasticmachine · 2023-05-03T16:40:55Z

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke

An error originating from public locations, for example addConfigs in the synthetics service, does not delete the integration policy, which was already created since public and private locations happen in parallel.

This creates an orphaned integration policy.

We should ensure that the integration policy is deleted if we encounter issues in public locations.

dominiqueclarke

Synthetics LGTM. The previous issue has been resolved.

dominiqueclarke · 2023-05-04T15:06:10Z

x-pack/plugins/synthetics/common/types/synthetics_monitor.ts

 export type DecryptedSyntheticsMonitorSavedObject = SimpleSavedObject<SyntheticsMonitor> & {
  updated_at: string;
 };

-export interface SyntheticsServiceAllowed {


Are these not in use?

yeah they aren't.

nchaulet

Fleet changes LGTM, it seems synthetics are the only using those bulk methods so it's probably okay to change those method behaviours

…ndling

kibana-ci · 2023-05-05T09:31:16Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: e810591

Failed CI Steps

FTR Configs #45

Test Failures

[job] [logs] FTR Configs #45 / expressions explorer emits an action and navigates

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`synthetics`	1.2MB	1.2MB	+63.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	48	47	-1
`securitySolution`	398	401	+3
total			+4

References to deprecated APIs

id	before	after	diff
`synthetics`	96	95	-1

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	58	57	-1
`securitySolution`	478	481	+3
total			+4

History

💔 Build #125713 failed 54ba8d4
💔 Build #125625 failed 4c5965d
💚 Build #125263 succeeded 1a06644
💚 Build #125123 succeeded 3dac62e
💔 Build #125092 failed c5c660c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co> (cherry picked from commit 1aba7df)

kibanamachine · 2023-05-05T09:38:59Z

💚 All backports created successfully

Status	Branch	Result
✅	8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…156807) # Backport This will backport the following commits from `main` to `8.8`: - [[Synthetics] Private location better error handling (#152695)](#152695)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Shahzad <shahzad31comp@gmail.com> Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>

add better error handling

6ccf699

shahzad31 force-pushed the better-error-handling branch from a5252ba to 6ccf699 Compare May 2, 2023 16:22

shahzad31 added 3 commits May 2, 2023 19:07

Merge branch 'main' of github.com:elastic/kibana into better-error-ha…

74fec8f

…ndling

update

1cd53dc

update

00bf100

dominiqueclarke self-requested a review May 3, 2023 00:40

dominiqueclarke requested changes May 3, 2023

View reviewed changes

dominiqueclarke reviewed May 3, 2023

View reviewed changes

fix tests

e5da186

shahzad31 force-pushed the better-error-handling branch from 16e2e90 to e5da186 Compare May 3, 2023 07:38

shahzad31 added 5 commits May 3, 2023 11:37

fix types

710bb04

update

2fa3d0f

fix more types

c5c660c

Merge branch 'main' of github.com:elastic/kibana into better-error-ha…

f836bc1

…ndling

update test

3dac62e

shahzad31 marked this pull request as ready for review May 3, 2023 12:14

shahzad31 requested review from a team as code owners May 3, 2023 12:14

shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.8.0 v8.9.0 labels May 3, 2023

dominiqueclarke self-requested a review May 3, 2023 13:37

add further error handling robustness

328af52

botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels May 3, 2023

dominiqueclarke requested changes May 3, 2023

View reviewed changes

adjust error handling

1a06644

dominiqueclarke self-requested a review May 4, 2023 13:23

improve error handling

4c5965d

dominiqueclarke approved these changes May 4, 2023

View reviewed changes

nchaulet self-requested a review May 4, 2023 18:56

nchaulet approved these changes May 5, 2023

View reviewed changes

shahzad31 added 5 commits May 5, 2023 07:22

Merge branch 'main' of github.com:elastic/kibana into better-error-ha…

99341c3

…ndling

update

54ba8d4

Merge branch 'main' of github.com:elastic/kibana into better-error-ha…

3b245b5

…ndling

update

0376dea

Merge branch 'main' of github.com:elastic/kibana into better-error-ha…

e810591

…ndling

shahzad31 merged commit 1aba7df into elastic:main May 5, 2023

shahzad31 deleted the better-error-handling branch May 5, 2023 09:32

kibanamachine mentioned this pull request May 5, 2023

[8.8] [Synthetics] Private location better error handling (#152695) #156807

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 5, 2023

[Synthetics] Private location better error handling (elastic#152695)

a218fa0

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co> (cherry picked from commit 1aba7df)

kibanamachine mentioned this pull request May 8, 2023

[Synthetics] quote monitor name to prevent invalid yaml #156210

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Synthetics] Private location better error handling #152695

[Synthetics] Private location better error handling #152695

shahzad31 commented Mar 6, 2023 •

edited by kibanamachine

Loading

dominiqueclarke left a comment

dominiqueclarke left a comment •

edited

Loading

elasticmachine commented May 3, 2023

elasticmachine commented May 3, 2023

dominiqueclarke left a comment

dominiqueclarke left a comment

dominiqueclarke May 4, 2023

shahzad31 May 4, 2023

nchaulet left a comment

kibana-ci commented May 5, 2023

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

kibanamachine commented May 5, 2023

[Synthetics] Private location better error handling #152695

[Synthetics] Private location better error handling #152695

Conversation

shahzad31 commented Mar 6, 2023 • edited by kibanamachine Loading

Testing Scope

UI Monitors

Project monitors

dominiqueclarke left a comment

Choose a reason for hiding this comment

dominiqueclarke left a comment • edited Loading

Choose a reason for hiding this comment

elasticmachine commented May 3, 2023

elasticmachine commented May 3, 2023

dominiqueclarke left a comment

Choose a reason for hiding this comment

dominiqueclarke left a comment

Choose a reason for hiding this comment

dominiqueclarke May 4, 2023

Choose a reason for hiding this comment

shahzad31 May 4, 2023

Choose a reason for hiding this comment

nchaulet left a comment

Choose a reason for hiding this comment

kibana-ci commented May 5, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

kibanamachine commented May 5, 2023

💚 All backports created successfully

Questions ?

shahzad31 commented Mar 6, 2023 •

edited by kibanamachine

Loading

dominiqueclarke left a comment •

edited

Loading