-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM][Security Solution][Alerts] moves legacy actions migration to rulesClient using hook in rules type definition #152362
[RAM][Security Solution][Alerts] moves legacy actions migration to rulesClient using hook in rules type definition #152362
Conversation
…ithub.com/vitaliidm/kibana into alerts/legacy-actions-migration-to-alerting # Conflicts: # x-pack/plugins/security_solution/server/lib/detection_engine/rule_actions_legacy/logic/rule_actions/legacy_rules_client_migration_hook.ts
…ithub.com/vitaliidm/kibana into alerts/legacy-actions-migration-to-alerting
…ithub.com/vitaliidm/kibana into alerts/legacy-actions-migration-to-alerting
…ithub.com/vitaliidm/kibana into alerts/legacy-actions-migration-to-alerting
…ithub.com/vitaliidm/kibana into alerts/legacy-actions-migration-to-alerting
@elasticmachine merge upstream |
merge conflict between base and head |
# Conflicts: # x-pack/plugins/alerting/server/index.ts # x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/rule_objects/update_prebuilt_rules.test.ts # x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/rule_objects/update_prebuilt_rules.ts
This reverts commit 889e983.
Leaving this PR for historical and tracking purposes as POC of moving legacy migration to rulesClient through hook in rule type definition. Further work, will be done in #153101, which is based on this, but migration will be implemented directly in RulesClient instead of passing as hook |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @vitaliidm |
Summary
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers