Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Makes connector configuration entries wrap text #151691

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Feb 21, 2023

Summary

This fixes a word wrap issue for connector configurations.

Before:
Screenshot 2023-02-21 at 13 00 39
After:
Screenshot 2023-02-21 at 12 59 43

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.7.0 v8.8.0 labels Feb 21, 2023
@sphilipse sphilipse requested a review from a team February 21, 2023 12:11
Copy link
Contributor

@timgrein timgrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sphilipse sphilipse enabled auto-merge (squash) February 21, 2023 12:55
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.2MB 2.2MB +66.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit 986b9b8 into elastic:main Feb 21, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 21, 2023
…lastic#151691)

## Summary

This fixes a word wrap issue for connector configurations.

Before:
<img width="975" alt="Screenshot 2023-02-21 at 13 00 39"
src="https://user-images.githubusercontent.com/94373878/220341403-57815e30-0119-4ff2-843d-5d0f5d424072.png">
After:
<img width="667" alt="Screenshot 2023-02-21 at 12 59 43"
src="https://user-images.githubusercontent.com/94373878/220341426-e68541ff-979a-48b4-a734-48450c5635b0.png">

(cherry picked from commit 986b9b8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 21, 2023
…text (#151691) (#151699)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Enterprise Search] Makes connector configuration entries wrap text
(#151691)](#151691)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-21T13:11:44Z","message":"[Enterprise
Search] Makes connector configuration entries wrap text (#151691)\n\n##
Summary\r\n\r\nThis fixes a word wrap issue for connector
configurations.\r\n\r\nBefore:\r\n<img width=\"975\" alt=\"Screenshot
2023-02-21 at 13 00
39\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341403-57815e30-0119-4ff2-843d-5d0f5d424072.png\">\r\nAfter:\r\n<img
width=\"667\" alt=\"Screenshot 2023-02-21 at 12 59
43\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341426-e68541ff-979a-48b4-a734-48450c5635b0.png\">","sha":"986b9b832d7cb9c59e160dddac25693329c2999d","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.7.0","v8.8.0"],"number":151691,"url":"https://github.com/elastic/kibana/pull/151691","mergeCommit":{"message":"[Enterprise
Search] Makes connector configuration entries wrap text (#151691)\n\n##
Summary\r\n\r\nThis fixes a word wrap issue for connector
configurations.\r\n\r\nBefore:\r\n<img width=\"975\" alt=\"Screenshot
2023-02-21 at 13 00
39\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341403-57815e30-0119-4ff2-843d-5d0f5d424072.png\">\r\nAfter:\r\n<img
width=\"667\" alt=\"Screenshot 2023-02-21 at 12 59
43\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341426-e68541ff-979a-48b4-a734-48450c5635b0.png\">","sha":"986b9b832d7cb9c59e160dddac25693329c2999d"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151691","number":151691,"mergeCommit":{"message":"[Enterprise
Search] Makes connector configuration entries wrap text (#151691)\n\n##
Summary\r\n\r\nThis fixes a word wrap issue for connector
configurations.\r\n\r\nBefore:\r\n<img width=\"975\" alt=\"Screenshot
2023-02-21 at 13 00
39\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341403-57815e30-0119-4ff2-843d-5d0f5d424072.png\">\r\nAfter:\r\n<img
width=\"667\" alt=\"Screenshot 2023-02-21 at 12 59
43\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341426-e68541ff-979a-48b4-a734-48450c5635b0.png\">","sha":"986b9b832d7cb9c59e160dddac25693329c2999d"}}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <94373878+sphilipse@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants