-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Makes connector configuration entries wrap text #151691
[Enterprise Search] Makes connector configuration entries wrap text #151691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
…lastic#151691) ## Summary This fixes a word wrap issue for connector configurations. Before: <img width="975" alt="Screenshot 2023-02-21 at 13 00 39" src="https://user-images.githubusercontent.com/94373878/220341403-57815e30-0119-4ff2-843d-5d0f5d424072.png"> After: <img width="667" alt="Screenshot 2023-02-21 at 12 59 43" src="https://user-images.githubusercontent.com/94373878/220341426-e68541ff-979a-48b4-a734-48450c5635b0.png"> (cherry picked from commit 986b9b8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…text (#151691) (#151699) # Backport This will backport the following commits from `main` to `8.7`: - [[Enterprise Search] Makes connector configuration entries wrap text (#151691)](#151691) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-21T13:11:44Z","message":"[Enterprise Search] Makes connector configuration entries wrap text (#151691)\n\n## Summary\r\n\r\nThis fixes a word wrap issue for connector configurations.\r\n\r\nBefore:\r\n<img width=\"975\" alt=\"Screenshot 2023-02-21 at 13 00 39\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341403-57815e30-0119-4ff2-843d-5d0f5d424072.png\">\r\nAfter:\r\n<img width=\"667\" alt=\"Screenshot 2023-02-21 at 12 59 43\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341426-e68541ff-979a-48b4-a734-48450c5635b0.png\">","sha":"986b9b832d7cb9c59e160dddac25693329c2999d","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.7.0","v8.8.0"],"number":151691,"url":"https://github.com/elastic/kibana/pull/151691","mergeCommit":{"message":"[Enterprise Search] Makes connector configuration entries wrap text (#151691)\n\n## Summary\r\n\r\nThis fixes a word wrap issue for connector configurations.\r\n\r\nBefore:\r\n<img width=\"975\" alt=\"Screenshot 2023-02-21 at 13 00 39\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341403-57815e30-0119-4ff2-843d-5d0f5d424072.png\">\r\nAfter:\r\n<img width=\"667\" alt=\"Screenshot 2023-02-21 at 12 59 43\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341426-e68541ff-979a-48b4-a734-48450c5635b0.png\">","sha":"986b9b832d7cb9c59e160dddac25693329c2999d"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151691","number":151691,"mergeCommit":{"message":"[Enterprise Search] Makes connector configuration entries wrap text (#151691)\n\n## Summary\r\n\r\nThis fixes a word wrap issue for connector configurations.\r\n\r\nBefore:\r\n<img width=\"975\" alt=\"Screenshot 2023-02-21 at 13 00 39\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341403-57815e30-0119-4ff2-843d-5d0f5d424072.png\">\r\nAfter:\r\n<img width=\"667\" alt=\"Screenshot 2023-02-21 at 12 59 43\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/220341426-e68541ff-979a-48b4-a734-48450c5635b0.png\">","sha":"986b9b832d7cb9c59e160dddac25693329c2999d"}}]}] BACKPORT--> Co-authored-by: Sander Philipse <94373878+sphilipse@users.noreply.github.com>
Summary
This fixes a word wrap issue for connector configurations.
Before:


After: