Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix Elasticsearch query rule for "KQL or Lucene" query without filters #151632

Merged
merged 4 commits into from
Feb 21, 2023
Merged

[Discover] Fix Elasticsearch query rule for "KQL or Lucene" query without filters #151632

merged 4 commits into from
Feb 21, 2023

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Feb 20, 2023 •
edited by kibanamachine
Loading

Closes #151609

For testing:

  • Go to Rule Management page
  • Create a new Rule with "Elasticsearch query" type in "KQL or Lucene" format
  • Save and check the status after the rule finishes the creating process => It should say "Succeeded"

@jughosta jughosta added release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Feb 20, 2023
@jughosta jughosta self-assigned this Feb 20, 2023
@jughosta jughosta marked this pull request as ready for review February 20, 2023 16:36
@jughosta jughosta requested review from a team as code owners February 20, 2023 16:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

ersin-erdal
ersin-erdal approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kertal
kertal approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx for fixing it so quickly. tested locally and a failing rule turned into a functional one with this PR
Bildschirmfoto 2023-02-21 um 11 59 32

@jughosta jughosta enabled auto-merge (squash) February 21, 2023 11:08
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta merged commit 17ab3a3 into elastic:main Feb 21, 2023
@kibanamachine kibanamachine mentioned this pull request Feb 21, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 21, 2023
@jughosta
[Discover] Fix Elasticsearch query rule for "KQL or Lucene" query wit…
d2e0c2e 
…hout filters (elastic#151632)

Closes elastic#151609

For testing:
- Go to Rule Management page
- Create a new Rule with "Elasticsearch query" type in "KQL or Lucene"
format
- Save and check the status after the rule finishes the creating process
=> It should say "Succeeded"

(cherry picked from commit 17ab3a3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 21, 2023
@kibanamachine @jughosta
[8.7] [Discover] Fix Elasticsearch query rule for "KQL or Lucene" que…
ba57a80 
…ry without filters (#151632) (#151705)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Discover] Fix Elasticsearch query rule for "KQL or Lucene" query
without filters
(#151632)](#151632)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-02-21T13:46:42Z","message":"[Discover]
Fix Elasticsearch query rule for \"KQL or Lucene\" query without filters
(#151632)\n\nCloses #151609
\r\n\r\nFor testing:\r\n- Go to Rule Management page\r\n- Create a new
Rule with \"Elasticsearch query\" type in \"KQL or
Lucene\"\r\nformat\r\n- Save and check the status after the rule
finishes the creating process\r\n=> It should say
\"Succeeded\"","sha":"17ab3a31dd8528d92d3c4a928b7e0923a48b037a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.8.0"],"number":151632,"url":"https://github.com/elastic/kibana/pull/151632","mergeCommit":{"message":"[Discover]
Fix Elasticsearch query rule for \"KQL or Lucene\" query without filters
(#151632)\n\nCloses #151609
\r\n\r\nFor testing:\r\n- Go to Rule Management page\r\n- Create a new
Rule with \"Elasticsearch query\" type in \"KQL or
Lucene\"\r\nformat\r\n- Save and check the status after the rule
finishes the creating process\r\n=> It should say
\"Succeeded\"","sha":"17ab3a31dd8528d92d3c4a928b7e0923a48b037a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151632","number":151632,"mergeCommit":{"message":"[Discover]
Fix Elasticsearch query rule for \"KQL or Lucene\" query without filters
(#151632)\n\nCloses #151609
\r\n\r\nFor testing:\r\n- Go to Rule Management page\r\n- Create a new
Rule with \"Elasticsearch query\" type in \"KQL or
Lucene\"\r\nformat\r\n- Save and check the status after the rule
finishes the creating process\r\n=> It should say
\"Succeeded\"","sha":"17ab3a31dd8528d92d3c4a928b7e0923a48b037a"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ersin-erdal ersin-erdal ersin-erdal approved these changes

@kertal kertal kertal approved these changes

Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elasticsearch query rule doesn't work with "KQL or Lucene" query
6 participants
@jughosta @elasticmachine @kibana-ci @kibanamachine @kertal @ersin-erdal