[Custom Branding] Update text #151631
Merged
[Custom Branding] Update text #151631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are a few suggestions: Change Company name to
Add the file type and size in the 2 upload boxes on the right:
Capitalize svg in this sentence
In the Favicon(SVG) and Favicon(PNG) text fields, add placeholder text that shows a link. Something like: |
|
@gchaps Unfortunately, we cannot add placeholders here. |
|
@majagrubic So then instead of the word "link" for the favicon text, I think "URL" would be more specific:
|
vadimkibana
approved these changes
Mar 9, 2023
Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
@majagrubic Is is possible to add file type and size in the 2 upload boxes on the right. The text would be:
|
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
## Summary This PR updates text for Custom Branding. <img width="1505" alt="Screenshot 2023-02-20 at 16 22 10" src="https://user-images.githubusercontent.com/1937956/220145333-68aedb04-5c57-4dca-aa1f-037a245100ba.png"> ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials ~- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ ~- [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))~ ~- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~ ~- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ ~- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~ ~- [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>
|
Pinging @elastic/kibana-core (Team:Core) |
This was referenced May 15, 2023
KOTungseth
added a commit
that referenced
this pull request
May 15, 2023
## Summary Adds the 8.8 docs for Kibana Global Settings, including #151631. Docs preview: https://kibana_157769.docs-preview.app.elstc.co/guide/en/kibana/master/advanced-options.html#kibana-global-settings-reference
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 15, 2023
## Summary Adds the 8.8 docs for Kibana Global Settings, including elastic#151631. Docs preview: https://kibana_157769.docs-preview.app.elstc.co/guide/en/kibana/master/advanced-options.html#kibana-global-settings-reference (cherry picked from commit 037ff39)
kibanamachine
added a commit
that referenced
this pull request
May 15, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [[DOCS] Adds Global Settings (#157769)](#157769) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kaarina Tungseth","email":"kaarina.tungseth@elastic.co"},"sourceCommit":{"committedDate":"2023-05-15T17:41:51Z","message":"[DOCS] Adds Global Settings (#157769)\n\n## Summary\r\n\r\nAdds the 8.8 docs for Kibana Global Settings, including\r\nhttps://github.com//pull/151631.\r\n\r\nDocs preview:\r\nhttps://kibana_157769.docs-preview.app.elstc.co/guide/en/kibana/master/advanced-options.html#kibana-global-settings-reference","sha":"037ff39062e81f0e3a39af8c606007247bd4794c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","Team:SharedUX","v8.8.0","v8.9.0"],"number":157769,"url":"https://github.com/elastic/kibana/pull/157769","mergeCommit":{"message":"[DOCS] Adds Global Settings (#157769)\n\n## Summary\r\n\r\nAdds the 8.8 docs for Kibana Global Settings, including\r\nhttps://github.com//pull/151631.\r\n\r\nDocs preview:\r\nhttps://kibana_157769.docs-preview.app.elstc.co/guide/en/kibana/master/advanced-options.html#kibana-global-settings-reference","sha":"037ff39062e81f0e3a39af8c606007247bd4794c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157769","number":157769,"mergeCommit":{"message":"[DOCS] Adds Global Settings (#157769)\n\n## Summary\r\n\r\nAdds the 8.8 docs for Kibana Global Settings, including\r\nhttps://github.com//pull/151631.\r\n\r\nDocs preview:\r\nhttps://kibana_157769.docs-preview.app.elstc.co/guide/en/kibana/master/advanced-options.html#kibana-global-settings-reference","sha":"037ff39062e81f0e3a39af8c606007247bd4794c"}}]}] BACKPORT--> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
## Summary Adds the 8.8 docs for Kibana Global Settings, including #151631. Docs preview: https://kibana_157769.docs-preview.app.elstc.co/guide/en/kibana/master/advanced-options.html#kibana-global-settings-reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates text for Custom Branding.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)- [ ] This was checked for cross-browser compatibilityFor maintainers