Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dialogue box for output_format field in Date processor #151445

Merged
merged 6 commits into from
Feb 21, 2023

Conversation

ElenaStoeva
Copy link
Contributor

Partially addresses #134164

Summary

Since Elasticsearch 8.0, the output_format field of the Date processor no longer accepts the formats ISO8601, UNIX, UNIX_MS, or TAI64N. (Link to docs). This PR updates the dialogue box of this field accordingly.

PR

Checklist

@ElenaStoeva ElenaStoeva added release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Ingest Node Pipelines Ingest node pipelines management labels Feb 16, 2023
@ElenaStoeva ElenaStoeva self-assigned this Feb 16, 2023
@ElenaStoeva ElenaStoeva marked this pull request as ready for review February 16, 2023 15:48
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner February 16, 2023 15:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a look at the copy changes and seems alright to me. Left a small note on the codeowners file

@@ -461,6 +461,7 @@ src/plugins/newsfeed @elastic/kibana-core
test/common/plugins/newsfeed @elastic/kibana-core
x-pack/plugins/notifications @elastic/appex-sharedux
x-pack/test/cases_api_integration/common/plugins/observability @elastic/response-ops
x-pack/plugins/observability @elastic/observability-ui
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this is a change we would want to be making here, right? Perhaps was a merge error that went unnoticed? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @kibanamachine automatically added this line in cacd82b. I thought it might be necessary so I left it as it is. I will try deleting it and see if it will be added again.

@ElenaStoeva
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 435.7KB 435.4KB -260.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.8.0 and removed release_note:fix labels Feb 21, 2023
@ElenaStoeva ElenaStoeva merged commit ddae353 into elastic:main Feb 21, 2023
@ElenaStoeva ElenaStoeva deleted the ingest-pipelines-dialogue-box branch February 21, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants