Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Removes Detection Rules version bump logic #151392

Merged
merged 92 commits into from
Mar 24, 2023

Conversation

spong
Copy link
Member

@spong spong commented Feb 16, 2023

Summary

Resolves #137168 by removing the logic to bump the version of security rules. Also adds an SO migration to set the initial revision as the current version.

Note: this was originally a branched off #147398, so the large commit list is resulting from there as Github doesn't seem to re-write after after a rebase w/ main and a force push.

Checklist

  • Documentation was added for features that require explanation or tutorials
    • Found no reference with regards to the auto-incrementing version logic in current docs.
  • Unit or functional tests were updated or added to match the most common scenarios

spong added 30 commits December 12, 2022 15:01
@spong spong force-pushed the removes-version-bump branch from 5339927 to 689648b Compare March 10, 2023 22:59
@spong spong changed the base branch from main to 8.7 March 22, 2023 17:50
@spong spong changed the base branch from 8.7 to main March 22, 2023 17:50
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Bulk editing index patterns of rules with index patterns and rules with a data view Add index patterns to custom rules: one rule is updated, one rule is skipped

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spong

@spong spong marked this pull request as ready for review March 24, 2023 03:52
@spong spong requested review from a team as code owners March 24, 2023 03:52
@spong spong requested a review from maximpn March 24, 2023 03:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spong spong merged commit f1dbb30 into elastic:main Mar 24, 2023
@spong spong deleted the removes-version-bump branch March 24, 2023 22:46
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] Remove logic that bumps rule version on every change
6 participants