[data views] Time series counter fields are not aggregatable #150954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
davismcphee
approved these changes
Feb 14, 2023
thomasneirynck
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
code review.
Confirmed in Kibana errors are still being thrown with regular data-streams. Will first need fix on ES-side outlined here: elastic/elasticsearch#93749 (comment) . Ie. allow all aggs on counter-fields when index-mode is not set to time_series
kibanamachine
pushed a commit
that referenced
this pull request
Feb 15, 2023
## Summary Part of elastic/elasticsearch#93539 Currently, field caps reports time series counter fields as aggregatable as they support several aggs. Unfortunately, they don't support ALL aggs so its possible create an unsupported agg in Kibana which results in an ES error. In order to prevent this, the data view field list will report all time series counter fields as non-aggregatable until support for specific aggs can be provided throughout Kibana. To test - Create a TSDS with a time series counter field and verify that its not aggregatable in data view management. Also check other apps to make sure the field isn't available for aggregations. https://www.elastic.co/guide/en/elasticsearch/reference/master/set-up-tsds.html ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 410f019)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Feb 15, 2023
…150954) (#151240) # Backport This will backport the following commits from `main` to `8.7`: - [[data views] Time series counter fields are not aggregatable (#150954)](#150954) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2023-02-15T00:38:23Z","message":"[data views] Time series counter fields are not aggregatable (#150954)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/elasticsearch/issues/93539\r\n\r\nCurrently, field caps reports time series counter fields as aggregatable\r\nas they support several aggs. Unfortunately, they don't support ALL aggs\r\nso its possible create an unsupported agg in Kibana which results in an\r\nES error. In order to prevent this, the data view field list will report\r\nall time series counter fields as non-aggregatable until support for\r\nspecific aggs can be provided throughout Kibana.\r\n\r\nTo test - Create a TSDS with a time series counter field and verify that\r\nits not aggregatable in data view management. Also check other apps to\r\nmake sure the field isn't available for aggregations.\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/master/set-up-tsds.html\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"410f0199408b2c55389ed7d6dfd3170cdede2c84","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","auto-backport","v8.7.0","v8.8.0","Feature: TSDS"],"number":150954,"url":"https://github.com/elastic/kibana/pull/150954","mergeCommit":{"message":"[data views] Time series counter fields are not aggregatable (#150954)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/elasticsearch/issues/93539\r\n\r\nCurrently, field caps reports time series counter fields as aggregatable\r\nas they support several aggs. Unfortunately, they don't support ALL aggs\r\nso its possible create an unsupported agg in Kibana which results in an\r\nES error. In order to prevent this, the data view field list will report\r\nall time series counter fields as non-aggregatable until support for\r\nspecific aggs can be provided throughout Kibana.\r\n\r\nTo test - Create a TSDS with a time series counter field and verify that\r\nits not aggregatable in data view management. Also check other apps to\r\nmake sure the field isn't available for aggregations.\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/master/set-up-tsds.html\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"410f0199408b2c55389ed7d6dfd3170cdede2c84"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150954","number":150954,"mergeCommit":{"message":"[data views] Time series counter fields are not aggregatable (#150954)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/elasticsearch/issues/93539\r\n\r\nCurrently, field caps reports time series counter fields as aggregatable\r\nas they support several aggs. Unfortunately, they don't support ALL aggs\r\nso its possible create an unsupported agg in Kibana which results in an\r\nES error. In order to prevent this, the data view field list will report\r\nall time series counter fields as non-aggregatable until support for\r\nspecific aggs can be provided throughout Kibana.\r\n\r\nTo test - Create a TSDS with a time series counter field and verify that\r\nits not aggregatable in data view management. Also check other apps to\r\nmake sure the field isn't available for aggregations.\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/master/set-up-tsds.html\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"410f0199408b2c55389ed7d6dfd3170cdede2c84"}}]}] BACKPORT--> Co-authored-by: Matthew Kime <matt@mattki.me>
justinkambic
pushed a commit
to justinkambic/kibana
that referenced
this pull request
Feb 23, 2023
…#150954) ## Summary Part of elastic/elasticsearch#93539 Currently, field caps reports time series counter fields as aggregatable as they support several aggs. Unfortunately, they don't support ALL aggs so its possible create an unsupported agg in Kibana which results in an ES error. In order to prevent this, the data view field list will report all time series counter fields as non-aggregatable until support for specific aggs can be provided throughout Kibana. To test - Create a TSDS with a time series counter field and verify that its not aggregatable in data view management. Also check other apps to make sure the field isn't available for aggregations. https://www.elastic.co/guide/en/elasticsearch/reference/master/set-up-tsds.html ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of elastic/elasticsearch#93539
Currently, field caps reports time series counter fields as aggregatable as they support several aggs. Unfortunately, they don't support ALL aggs so its possible create an unsupported agg in Kibana which results in an ES error. In order to prevent this, the data view field list will report all time series counter fields as non-aggregatable until support for specific aggs can be provided throughout Kibana.
To test - Create a TSDS with a time series counter field and verify that its not aggregatable in data view management. Also check other apps to make sure the field isn't available for aggregations. https://www.elastic.co/guide/en/elasticsearch/reference/master/set-up-tsds.html
Checklist
Delete any items that are not applicable to this PR.