Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics UI] Correct link in the integration deprecation callout #150879

Merged
merged 6 commits into from
Feb 21, 2023

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Feb 10, 2023

Closes #150872

@afgomez afgomez added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Feb 10, 2023
@afgomez afgomez requested review from a team as code owners February 10, 2023 13:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@afgomez afgomez enabled auto-merge (squash) February 10, 2023 13:34
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doclink LGTM

@afgomez afgomez force-pushed the 150872-correct-link-in-deprecation branch from da51d94 to 5e41a16 Compare February 16, 2023 09:54
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 152.5KB 152.6KB +108.0B
synthetics 1.4MB 1.4MB +87.0B
total +195.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 350.0KB 350.1KB +108.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 21, 2023
…lout (#150879) (#151706)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Synthetics UI] Correct link in the integration deprecation callout
(#150879)](#150879)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Gómez","email":"alejandro.fernandez@elastic.co"},"sourceCommit":{"committedDate":"2023-02-21T13:47:46Z","message":"[Synthetics
UI] Correct link in the integration deprecation callout
(#150879)\n\nCloses
#150872","sha":"f1fa5d764f6bd5e25cb9249aeb0a92ade1024de5","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.7.0","v8.8.0"],"number":150879,"url":"https://github.com/elastic/kibana/pull/150879","mergeCommit":{"message":"[Synthetics
UI] Correct link in the integration deprecation callout
(#150879)\n\nCloses
#150872","sha":"f1fa5d764f6bd5e25cb9249aeb0a92ade1024de5"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150879","number":150879,"mergeCommit":{"message":"[Synthetics
UI] Correct link in the integration deprecation callout
(#150879)\n\nCloses
#150872","sha":"f1fa5d764f6bd5e25cb9249aeb0a92ade1024de5"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics] Deprecation note docs link goes to the wrong place
6 participants