Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics UI] Add deprecation warnings for the synthetics integration monitors #150437

Merged
merged 7 commits into from
Feb 8, 2023
Merged

[Synthetics UI] Add deprecation warnings for the synthetics integration monitors #150437

merged 7 commits into from
Feb 8, 2023

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Feb 7, 2023 •
edited
Loading

Closes #150287

Summary

Adds or updates deprecation notices regarding the synthetics integration when the user has monitors created through it.

Screenshots

In the Uptime UI:

Screenshot 2023-02-07 at 15 10 37

When editing an integration:

Screenshot 2023-02-07 at 15 44 57

Alejandro Fernández Gómez added 6 commits February 7, 2023 14:36
s/zip_url/integration/g
e2169c9 
Generalize the deprecation from monitors that have a zip url to monitors
that are created via the synthetics integration
Update copy
892dae7
Rename folder
1e56255
Extract callout to its own component
b32b262
Add callout to the integration edit component
1f1fb8f
Fix translation files
08a67e0
@afgomez afgomez marked this pull request as ready for review February 7, 2023 14:48
@afgomez afgomez requested a review from a team as a code owner February 7, 2023 14:48
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Feb 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@afgomez afgomez added release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Feb 7, 2023
@afgomez afgomez force-pushed the 150287-synthetics-integration-warnings branch from 0df6704 to 4255147 Compare February 8, 2023 11:05
shahzad31
shahzad31 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1352 1353 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.4MB 1.4MB +580.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit 9aae30e into elastic:main Feb 8, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 8, 2023
@paulb-elastic paulb-elastic mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Synthetics] Notify legacy Synthetics integration being deprecated
5 participants
@afgomez @elasticmachine @kibana-ci @shahzad31 @kibanamachine