[Security Solution] integrate CellActions in Events/Alerts DataTables #149934
Conversation
…ithub.com/semd/kibana into 145666_cell_actions_datatable_integration
…_datatable_integration
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
x-pack/plugins/security_solution/public/common/components/data_table/index.tsx
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
| visibleCellActions: 3, | ||
| } | ||
| : {}), | ||
| cellActions: columnsCellActions[columnIndex] ?? [], |
There was a problem hiding this comment.
This is the beauty - how simpler it is now!
| @@ -569,17 +566,15 @@ const StatefulEventsViewerComponent: React.FC<EventsViewerProps & PropsFromRedux | |||
| unitCountText={unitCountText} | |||
| browserFields={browserFields} | |||
| data={nonDeletedEvents} | |||
| disabledCellActions={FIELDS_WITHOUT_CELL_ACTIONS} | |||
| disableCellActions={disableCellActions} | |||
There was a problem hiding this comment.
I think we should also remove file x-pack/plugins/security_solution/public/common/lib/cell_actions/constants.ts because its FIELDS_WITHOUT_CELL_ACTIONS is not in use any more
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…ithub.com/semd/kibana into 145666_cell_actions_datatable_integration
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: cc @semd |
issue: #145666
Summary
Migrate DataTable component, used to render the alerts/events data grids in different pages: Alerts, Explore pages (Hosts, Users, Network), and also Rule preview. In summary, all data grids but Timeline.
The integration won't modify any action or change any functionality, everything is supposed to keep working the same way from the User's perspective. But it has a minor UI update in the actions tooltip layout:
old
new
This change was needed since the custom tooltip (old one) was adding too many Security-related customizations to the generic EuiDataGrid's columnCellActions, and also it had a lot of "action-specific" complexity, which is against the idea of having an action-agnostic generic component, to begin with.
So, in order to unify the CellActions user experience (icon, text, layout...), we needed to use a more uniformed component, that will render all the actions without any special case.