-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up dashboard padding and coloring #14811
Conversation
Looks great! To get tests passing you need to update the jest snapshots (run with |
@stacey-gammon Tests passing. This just merges to master right, does it need backporting? |
Failed on:
lets see if this is flaky, jenkins, test this |
it will need to be backported to 6.x @snide. lets wait to merge till the ci passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes some coloring issues with dashboards with the new margin settings. Makes everything consistent between mode / theme.
Fixes some coloring issues with dashboards with the new margin settings. Makes everything consistent between mode / theme.
Cleans up the new dashboards with margins. Makes the following changes.
Things that aren't super fixable without aggressive CSS.
@stacey-gammon I only tested this with some dummy dashboards I had. If you can run it through some of yours I'd appreciate it. I don't necessarily know where some of this stuff gets pulled in.