Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deprecations] Remove/update core-api deprecations targeted for removal by 8.8 #147723

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address some PR comments
  • Loading branch information
TinaHeiligers committed Dec 19, 2022
commit 749677670d23738397e1b413e73c579075bf8f5e
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ import type { EuiButtonColor } from '@elastic/eui';
*
* See {@link AppMountParameters} for detailed usage examples.
*
* @remarks prefer {@link ScopedHistory.block} instead
*
* @public
*/
export type AppLeaveHandler = (
factory: AppLeaveActionFactory,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ export interface AppMountParameters<HistoryLocationState = unknown> {
* The route path for configuring navigation to the application.
* This string should not include the base path from HTTP.
*
* @deprecated Use {@link AppMountParameters.history} instead.
* @removeBy 8.8.0
*
* @example
*
* How to configure react-router with a base path:
Expand Down
2 changes: 1 addition & 1 deletion test/analytics/tests/analytics_from_the_browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

it('should call flush when using the window-exposed flush method', async () => {
await browser.execute(() => window.__kbnAnalytics.flush());
// @ts-ignore-next-line Property 'getFlushAction' does not exist on type '{ getActionsUntilReportTestPluginLifecycleEvent:
// @ts-expect-error Property 'getFlushAction' does not exist on type '{ getActionsUntilReportTestPluginLifecycleEvent:
const action = await browser.execute(() => window.__analyticsPluginA__.getFlushAction());
expect(action).to.eql({ action: 'flush', meta: {} });
});
Expand Down