[Actionable Observability] - Formate Actual value and the Expected value in Alert Details

[fkanout]

Summary

Closes #145409 by formatting the Actual value and the Expected value.

[elasticmachine]

Pinging @elastic/actionable-observability (Team: Actionable Observability)

[CoenWarmer]

Looks good already, small remark.

[maryam-saeidi]

Just thinking out loud:
Does it make sense that the Observability plugin knows about specific details of the APM rule types? I am wondering if this logic is something that should be provided by each app or if we should handle it like this in the Observability plugin. (Especially if we will have similar scenarios for each rule type)
@fkanout @simianhacker What do you think?

[fkanout]

@maryam-saeidi, it's a good question. The goal was to make the AlertSummary sharable, and then each App will import it and then use their logic/formatter.

However, when I started implementation, I realized that

• APM (most likely other Apps) don't have formatters, AND they are importing and using Observability formatter.
• Doing the formatting at the Rule level is not ideal, as we only have three types of values that need to be formatted across all rule types.

[maryam-saeidi]

Interesting.

It makes sense that Observability shares formatter since the formatting logic can be re-used in different rule types.

The concern here is to spread the logic related to rules in multiple plugins and make the Observability plugin unnecessarily aware of details of each rule type and as a result, in case of any change or addition, to always update this plugin as well. So basically, we are affecting the separation of concern here.

Doing the formatting at the Rule level is not ideal, as we only have three types of values that need to be formatted across all rule types.

Also, can you please elaborate on why it is not ideal? What issues it might cause?

[maryam-saeidi]

Tested locally, and looks nice! 👍🏻

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: ca4db3a

Failed CI Steps

• FTR Configs #48

Test Failures

• [job] [logs] FTR Configs #48 / APM API tests basic no data Service group counts with alerts "before all" hook for "returns the correct number of alerts"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
observability	460	462	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
observability	502.7KB	503.0KB	+288.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
observability	79.5KB	79.6KB	+108.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
osquery	1	2	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
fleet	61	67	+6
osquery	109	115	+6
securitySolution	440	446	+6
total			+20

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
fleet	70	76	+6
osquery	110	117	+7
securitySolution	517	523	+6
total			+21

History

• 💛 Build #95160 was flaky e50602f
• 💔 Build #95101 failed cf47806
• 💔 Build #94948 failed 0f56a8d
• 💔 Build #93663 failed 88d570b
• 💔 Build #93653 failed 04e7e72
• 💔 Build #93571 failed f4f3cc9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @fkanout