Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix flaky "visualize in lens" test #146863

Merged
merged 8 commits into from
Dec 6, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Dec 2, 2022

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Dec 2, 2022
@jughosta jughosta self-assigned this Dec 2, 2022
@jughosta jughosta changed the title [Discover] Fix flaky management test [Discover] Fix flaky "visualize in lens" test Dec 2, 2022
@jughosta jughosta marked this pull request as ready for review December 2, 2022 12:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta requested a review from a team December 2, 2022 12:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only, LGTM. Thanks for the flaky fix!

@jughosta jughosta merged commit 61930b7 into elastic:main Dec 6, 2022
@jughosta jughosta deleted the 141616-flaky-test-lens branch December 6, 2022 08:09
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.6 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.6:
- [Discover] Fix flaky runtime field test (#147006)

Manual backport

To create the backport manually run:

node scripts/backport --pr 146863

Questions ?

Please refer to the Backport tool documentation

@jughosta
Copy link
Contributor Author

jughosta commented Dec 6, 2022

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jughosta added a commit to jughosta/kibana that referenced this pull request Dec 6, 2022
jughosta added a commit that referenced this pull request Dec 6, 2022
# Backport

This will backport the following commits from `main` to `8.6`:
- [[Discover] Fix flaky "visualize in lens" test
(#146863)](#146863)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2022-12-06T08:09:21Z","message":"[Discover]
Fix flaky \"visualize in lens\" test (#146863)\n\nCloses
https://github.com/elastic/kibana/issues/141616\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1615","sha":"61930b7ef92a1c652f2c2e1c7f49c6da1988f6ac","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.7.0"],"number":146863,"url":"https://github.com/elastic/kibana/pull/146863","mergeCommit":{"message":"[Discover]
Fix flaky \"visualize in lens\" test (#146863)\n\nCloses
https://github.com/elastic/kibana/issues/141616\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1615","sha":"61930b7ef92a1c652f2c2e1c7f49c6da1988f6ac"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146863","number":146863,"mergeCommit":{"message":"[Discover]
Fix flaky \"visualize in lens\" test (#146863)\n\nCloses
https://github.com/elastic/kibana/issues/141616\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1615","sha":"61930b7ef92a1c652f2c2e1c7f49c6da1988f6ac"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.6.0 v8.7.0
Projects
None yet
5 participants