[Synthetics] fix failing Private location tests #146484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c453c6e to
1f8cd26
Compare
dominiqueclarke
commented
Dec 2, 2022
x-pack/test/api_integration/apis/synthetics/get_monitor_overview.ts
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/uptime (Team:uptime) |
|
@elasticmachine merge upstream |
This was referenced Dec 2, 2022
awahab07
approved these changes
Dec 2, 2022
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dominiqueclarke
added a commit
to dominiqueclarke/kibana
that referenced
this pull request
Dec 2, 2022
## Summary Resolves elastic#145639 Uses semver to test whether or not Synthetics policies is able to be auto upgraded through the Fleet auto upgrade flow, rather than relying on a specific version. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit f9b906e) # Conflicts: # x-pack/test/api_integration/apis/synthetics/add_monitor_private_location.ts
dominiqueclarke
added a commit
that referenced
this pull request
Dec 2, 2022
) # Backport This will backport the following commits from `main` to `8.6`: - [[Synthetics] fix failing Private location tests (#146484)](#146484) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2022-12-02T18:28:49Z","message":"[Synthetics] fix failing Private location tests (#146484)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/145639\r\n\r\nUses semver to test whether or not Synthetics policies is able to be\r\nauto upgraded through the Fleet auto upgrade flow, rather than relying\r\non a specific version.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"f9b906e39850ea208f3a0758c46b4fec132e9538","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:uptime","release_note:skip","v8.6.0","v8.7.0"],"number":146484,"url":"https://github.com/elastic/kibana/pull/146484","mergeCommit":{"message":"[Synthetics] fix failing Private location tests (#146484)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/145639\r\n\r\nUses semver to test whether or not Synthetics policies is able to be\r\nauto upgraded through the Fleet auto upgrade flow, rather than relying\r\non a specific version.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"f9b906e39850ea208f3a0758c46b4fec132e9538"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146484","number":146484,"mergeCommit":{"message":"[Synthetics] fix failing Private location tests (#146484)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/145639\r\n\r\nUses semver to test whether or not Synthetics policies is able to be\r\nauto upgraded through the Fleet auto upgrade flow, rather than relying\r\non a specific version.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"f9b906e39850ea208f3a0758c46b4fec132e9538"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #145639
Uses semver to test whether or not Synthetics policies is able to be auto upgraded through the Fleet auto upgrade flow, rather than relying on a specific version.