Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics UI] Add pagination and date filtering to test runs table #144029

Merged
merged 14 commits into from
Oct 31, 2022

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Oct 26, 2022

Summary

Adds pagination and date ranges to the Test Runs table. This enables us to reuse the table in the history panel.

Testing

Since the table in the summary page is not paginated, you'll need to change the paginable={true} prop inside monitor_summary.tsx.

Known issues

The "Last test run" block uses the first element in the pings.data array. When the user paginates this element changes. I have two approaches in mind to solve this:

  1. Cache all loaded pings in memory. The advantage of this approach is performance when the user goes back and forth between pages that have already been loaded. The disadvantage is that we would need to do a lot of book-keeping with what pings are loaded and which ones go into each page when the user changes the number of elements per page.
  2. Track and load the last test run separatedly. This makes the code way simpler, but we have to make on extra request.

So far I'm inclined for the last option, but I'd like to get feedback from the reviewers.

@afgomez afgomez added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Oct 26, 2022
@afgomez afgomez requested a review from a team as a code owner October 26, 2022 12:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@afgomez afgomez force-pushed the 143514-paginate-runs-table branch from cc2c491 to d55adce Compare October 26, 2022 12:36
@afgomez afgomez force-pushed the 143514-paginate-runs-table branch from d55adce to 0e62d4e Compare October 26, 2022 14:03
@afgomez afgomez changed the title [Synthetics UI] Add pagination and [Synthetics UI] Add pagination and date filtering to test runs table Oct 27, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1022 1023 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.0MB 1.0MB +862.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 443 +4
total +17

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 520 +4
total +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit fdce066 into elastic:main Oct 31, 2022
@afgomez afgomez deleted the 143514-paginate-runs-table branch October 31, 2022 12:33
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 31, 2022
@afgomez afgomez linked an issue Oct 31, 2022 that may be closed by this pull request
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 31, 2022
* main:
  Upgrade @elastic/makelogs from v6.0.0 to v6.1.1 (elastic#144231)
  [Files] move to src (elastic#144044)
  [Synthetics UI] Add pagination and date filtering to test runs table (elastic#144029)
  Update time range when opening timeline from Entity Analytics page (elastic#144024)
  [Security Solution] Added guided onboarding for the rules area (elastic#144016)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 31, 2022
* main:
  [Fleet] Add the @Custom pipeline only to the main datastream ingest pipelines (elastic#144150)
  Upgrade @elastic/makelogs from v6.0.0 to v6.1.1 (elastic#144231)
  [Files] move to src (elastic#144044)
  [Synthetics UI] Add pagination and date filtering to test runs table (elastic#144029)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics UI] Add pagination to the test runs table component
5 participants