[APM] AWS lambda estimated cost #143986

cauemarcondes · 2022-10-25T19:23:19Z

elasticmachine · 2022-10-25T19:23:25Z

Pinging @elastic/apm-ui (Team:APM)

kpatticha · 2022-10-27T09:55:10Z

x-pack/plugins/apm/server/routes/services/get_service_metadata_details.ts

@@ -212,6 +213,7 @@ export async function getServiceMetadataDetails({
          faasTriggerTypes: response.aggregations?.faasTriggerTypes.buckets.map(
            (bucket) => bucket.key as string
          ),
+          hostArchitecture: host?.architecture,


is it possible that a service could have N lambda functions with different architectures?

in that case, which architecture do we display in the popup?

Yes, it is possible. We agreed to show the most recent one so I'm going to sort the result.

Can you please elaborate why the recent one cause it's a little bit confusing to me 🙈, usually in the popup we display summary metadata for the service.

when I see the following:

I expect both functions have arm architecture. (but it can be different)

I think, for the popup can be solved with simple terms agg on the host.architecture.

I'm afraid if we show both the user might be confused about the estimated cost. As we use the most recent one there. @AlexanderWert WDYT? should we show a list of architecture here or just the most recent?

@caue The point about the recent one was in the case that someone changes the architecture of a specific function (even with APM services that have only a single function associated).
But if we have an APM service with multiple functions, I think we should show both here.

TBH I haven't thought about the cost estimation for a service that has multiple different functions (with different architectures and different memory sizes).

I think, in this case we would need to calculate the cost for each function individually and then sum up the result. Not only because of the architecture but also because they might have different memory sizes, which also influences the costs significantly. Not sure if we are doing this here already or how complicated that would be?

But I think for this first iteration it's also fine to just keep it simple and show an estimate based on the recent values. (The default setup is anyways a 1:1 mapping between function and APM service)

Agreed with @AlexanderWert that I'll try to tackle this on another PR.

kpatticha · 2022-10-27T09:59:13Z

x-pack/plugins/apm/public/components/app/metrics/serverless_metrics/serverless_summary.tsx

+            titleSize="s"
+            description={i18n.translate(
+              'xpack.apm.serverlessMetrics.summary.estimatedCost',
+              { defaultMessage: 'Estimated costs avg.' }


I think it would be useful to have a tooltip to inform the user how the avg cost is calculated

@boriskirov can you come up with a copy, please?

packages/kbn-apm-synthtrace/src/lib/apm/serverless_function.ts

x-pack/plugins/apm/server/routes/metrics/serverless/get_serverless_summary.ts

kpatticha

Thanks for addressing most of the feedback. 🙏 Overall the code looks good to me 💯

I believe the tooltip and the discussion around the architecture in the popup don't block this PR so It's up to you in case you'd like to address them in a follow up PR :D

Thanks 🥇

x-pack/plugins/apm/server/routes/metrics/serverless/get_serverless_summary.ts

x-pack/plugins/apm/server/routes/metrics/serverless/helper.test.ts

x-pack/plugins/apm/server/routes/metrics/serverless/helper.ts

dgieselaar · 2022-10-31T12:09:22Z

x-pack/plugins/apm/server/routes/metrics/serverless/helper.test.ts

+    const architecture = 'x86_64';
+    it('returns correct cost when usage is less than 6 b gb-sec', () => {
+      expect(
+        calcEstimatedCost({


I think it'd be useful to have several invocations here, it would make it more clear from just reading the test how different factors influence the final result.

x-pack/plugins/apm/server/routes/metrics/serverless/helper.ts

dgieselaar · 2022-10-31T12:10:43Z

x-pack/plugins/apm/server/routes/metrics/serverless/route.ts

+      uiSettingsClient
+        .get<string>(apmAWSLambdaPriceFactor)
+        .then(
+          (value): AWSLambdaPriceFactor =>
+            JSON.parse(value) as AWSLambdaPriceFactor
+        ),
+      uiSettingsClient.get<number>(apmAWSLambdaRequestCostPerMillion),


Is there no way to get multiple settings from the uiSettingsClient in one call? what does it do under the hood? does each call trigger an Elasticsearch request, or is it returned from a local cache?

There's a .getAll() function too. Under the hood .get(key) calls getAll but only returns the key received. And yes, the value is cached.

x-pack/plugins/apm/server/routes/metrics/serverless/get_serverless_summary.ts

…mated-cost

kibana-ci · 2022-10-31T19:20:44Z

💚 Build Succeeded

Buildkite Build
Commit: df8bd2f

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`observability`	538	552	+14

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`observability`	37	40	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.1MB	3.1MB	+580.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	68.0KB	68.3KB	+288.0B

Unknown metric groups

API count

id	before	after	diff
`observability`	541	555	+14

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	57	63	+6
`osquery`	103	108	+5
`securitySolution`	439	443	+4
total			+17

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	65	71	+6
`osquery`	104	110	+6
`securitySolution`	516	520	+4
total			+18

History

💔 Build #84070 failed 3394f13
💚 Build #83939 succeeded 9af962c
💚 Build #83220 succeeded dcb0999
💚 Build #82903 succeeded eac10bd
💔 Build #82827 failed f18a94e
💔 Build #82634 failed 4181937

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* main: (43 commits) [Synthetics] Step details page screenshot (elastic#143452) [Lens] Datatable expression types improvement. (elastic#144173) [packages/kbn-journeys] start apm after browser start and stop after browser is closed (elastic#144267) [Files] Make files namespace agnostic (elastic#144019) Implement base browser-side logging system (elastic#144107) Correct wrong multiplier for byte conversion (elastic#143751) [Monaco] Add JSON syntax support to the Monaco editor (elastic#143739) CCS Smoke Test for Remote Clusters and Index Management (elastic#142423) [api-docs] Daily api_docs build (elastic#144294) chore(NA): include progress on Bazel tasks (elastic#144275) [RAM] Allow users to see event logs from all spaces they have access to (elastic#140449) [APM] Show recommended minimum size when going below 5 minutes (elastic#144170) [typecheck] delete temporary target_types dirs in packages (elastic#144271) [Security Solution][Endpoint] adds new alert loading utility and un-skip FTR test for endpoint (elastic#144133) [performance/journeys] revert data_stress_test_lens.ts journey step (elastic#144261) [TIP] Use search strategies in Threat Intelligence (elastic#143267) Optimize react-query dependencies (elastic#144206) [babel/node] invalidate cache when synth pkg map is updated (elastic#144258) [APM] AWS lambda estimated cost (elastic#143986) [Maps] layer group wizard (elastic#144129) ...

cauemarcondes added 2 commits October 25, 2022 14:56

adding estimated cost

7b46afb

fixing

27d39f1

cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Oct 25, 2022

cauemarcondes requested review from a team as code owners October 25, 2022 19:23

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 25, 2022

adding architecture to service details

4181937

cauemarcondes mentioned this pull request Oct 25, 2022

[APM] Implement improvements to AWS Lambda metrics view #142328

Closed

2 tasks

pgayvallet approved these changes Oct 26, 2022

View reviewed changes

cauemarcondes added 2 commits October 26, 2022 09:06

fix ci

f18a94e

fix test

eac10bd

kpatticha reviewed Oct 27, 2022

View reviewed changes

packages/kbn-apm-synthtrace/src/lib/apm/serverless_function.ts Outdated Show resolved Hide resolved

kpatticha reviewed Oct 27, 2022

View reviewed changes

x-pack/plugins/apm/server/routes/metrics/serverless/get_serverless_summary.ts Outdated Show resolved Hide resolved

kpatticha reviewed Oct 27, 2022

View reviewed changes

x-pack/plugins/apm/server/routes/metrics/serverless/get_serverless_summary.ts Outdated Show resolved Hide resolved

addressing PR comments

dcb0999

cauemarcondes requested a review from kpatticha October 27, 2022 14:40

kpatticha approved these changes Oct 27, 2022

View reviewed changes