Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Dashboard addToTimeline action in Security Solution #143426

Closed
wants to merge 2 commits into from

Conversation

semd
Copy link
Contributor

@semd semd commented Oct 17, 2022

Summary

issue: #140304

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@semd semd self-assigned this Oct 17, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 17, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / DatatableComponent it renders actions column when there are row actions
  • [job] [logs] Jest Tests #9 / DatatableComponent it renders custom row height if set to another value than 1
  • [job] [logs] Jest Tests #9 / DatatableComponent it renders the title and value
  • [job] [logs] Jest Tests #9 / DatatableComponent it should render hide, reset, and sort actions on header even when it is in read only mode
  • [job] [logs] Jest Tests #8 / getLegendAction is rendered if layer is detected
  • [job] [logs] Jest Tests #8 / getLegendAction is rendered if row does not exist

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3165 3170 +5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
charts 249 252 +3
embeddable 412 422 +10
securitySolution 54 57 +3
visualizations 699 700 +1
total +17

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionPartitionVis 51.0KB 51.4KB +440.0B
expressionXY 119.0KB 119.4KB +436.0B
lens 1.3MB 1.3MB +1.0KB
securitySolution 6.6MB 4.9MB -1.6MB
visualizations 240.2KB 240.2KB +23.0B
total -1.6MB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
securitySolution 23 24 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff errors
embeddable 70.0KB 70.5KB +496.0B
expressionXY 37.0KB 37.1KB +58.0B
securitySolution 265.1KB 647.5KB ⚠️ +382.4KB ❌ 380.1KB over limit
visualizations 52.1KB 52.1KB +32.0B
total +382.9KB
Unknown metric groups

API count

id before after diff
charts 264 267 +3
embeddable 512 522 +10
securitySolution 55 58 +3
visualizations 729 730 +1
total +17

ESLint disabled in files

id before after diff
apm 14 13 -1
observability 8 7 -1
total -2

ESLint disabled line counts

id before after diff
apm 81 79 -2
observability 45 44 -1
securitySolution 411 408 -3
synthetics 60 54 -6
threatIntelligence 11 8 -3
ux 10 9 -1
total -16

Total ESLint disabled count

id before after diff
apm 95 92 -3
observability 53 51 -2
securitySolution 484 481 -3
synthetics 66 60 -6
threatIntelligence 12 9 -3
ux 13 12 -1
total -18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd
Copy link
Contributor Author

semd commented Dec 16, 2022

properly implemented at: #145708

@semd semd closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants